Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sort ticks by most recent #434

Merged
merged 1 commit into from
Nov 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/model/TickDataSource.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,10 @@ export default class TickDataSource extends MongoDataSource<TickType> {
throw new Error('No such user')
}
// Unfortunately, userIds on ticks are stored as strings not MUUIDs.
return await this.tickModel.find({ userId: userIdObject._id.toUUID().toString() })
return await this.tickModel
.find({ userId: userIdObject._id.toUUID().toString() })
.sort({ dateClimbed: -1 })
.lean()
}

/**
Expand All @@ -112,7 +115,10 @@ export default class TickDataSource extends MongoDataSource<TickType> {
* @param climbId climb uuid
*/
async ticksByUserIdAndClimb (climbId: string, userId?: string): Promise<TickType[]> {
return await this.tickModel.find({ ...(userId != null && { userId }), climbId }).sort({ dateClimbed: -1 }).lean()
return await this.tickModel
.find({ ...(userId != null && { userId }), climbId })
.sort({ dateClimbed: -1 })
.lean()
}

static instance: TickDataSource
Expand Down
Loading