feat: add Brazilian grade context (closes #358) #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enapupe
force-pushed
the
enapupe/add-brazilian-grade
branch
from
e02ddef to
57f2f71
Compare
enapupe
commented
Nov 10, 2023
enapupe
force-pushed
the
enapupe/add-brazilian-grade
branch
from
57f2f71 to
d9df965
Compare
Check against the PR where I added Australian: d44abd6 You can also try testing with a local version of the frontend. If there are issues that arise, tests should be expanded. |
enapupe
force-pushed
the
enapupe/add-brazilian-grade
branch
3 times, most recently
from
0e46088 to
814c414
Compare
enapupe
commented
Nov 10, 2023
vnugent
requested changes
Nov 10, 2023
Define BR context. Brazil uses vscale for bouldering, WI placeholder ice/snow related. AID is currently matching the general AID definition though it has to be confirmed later if they are the same or if there will be a fork.
enapupe
force-pushed
the
enapupe/add-brazilian-grade
branch
from
814c414 to
e6d69f5
Compare
|
I'll have to check the database to see if we need to set this new context for Brazil at the country level so that areas can inherit it. |
|
@all-contributors add @enapupe for code |
|
I've put up a pull request to add @enapupe! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces and links Brazilian Crux grade to the backend.
@musoke This was my first interaction with graphql so I'm not sure if there's any missing pieces, the codebase seemed ready to accept a new context without much tweaking.