Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boltsCount field #323

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Conversation

l4u532
Copy link
Contributor

@l4u532 l4u532 commented Jul 1, 2023

Add boltsCount to store number of fixed anchors in a route. Especially for multi-pitch climbing and sport climbing in Central Europe (where the vast majority of crags has fixed anchors).

Prerequisite to implementing multi-pitch functionality (#266).

@l4u532
Copy link
Contributor Author

l4u532 commented Jul 1, 2023

@musoke May I kindly as you for some feedback to this PR? thx :)

@l4u532 l4u532 marked this pull request as ready for review July 3, 2023 15:04
Copy link
Contributor

@musoke musoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Maybe add a tests for unknown and 0 bolts?
@vnugent will probably have thoughts too.

@musoke musoke requested a review from vnugent July 3, 2023 17:53
@vnugent vnugent merged commit 7191b15 into OpenBeta:develop Jul 3, 2023
@vnugent
Copy link
Contributor

vnugent commented Jul 3, 2023

FYI build deployed to staging and production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants