Photogallerymodal tags

[clintonlunn]

---

name: Pull request
about: Adding the taglist to the PhotoGalleryModal, add username to TagList

---

What type of PR is this?(check all applicable)

• refactor
• feature
• bug fix
• documentation
• optimization
• other

Description

Refactored the previous Tag component into three separate components: BaseTag, LocationTag, and UsernameTag. In addition, there is a boolean flag to render the UsernameTag within the TagList. This can maybe be refactored in the future to include a list of tagtypes to include in the list. This results in the username tag only being included in certain parts of the app since we have username tags elsewhere in other parts of the app.

Related Issues

Issue #645

What this PR achieves

Screenshots, recordings

Notes

[clintonlunn]

@vnugent i'm really not sure why the test build step gets skipped. but if you pull down my branch, you'll see the failing tests

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
open-tacos	✅ Ready (Inspect)	Visit Preview	Nov 20, 2023 0:13am

[vnugent]

• I fixed the failing test and also relaxed some conditions in .github action file to make sure tests are run
• Rebased your working branch with the latest develop. You should do pull to get the latest. Also run yarn install to pick up library upgrades.

[clintonlunn]

• I fixed the failing test and also relaxed some conditions in .github action file to make sure tests are run
• Rebased your working branch with the latest develop. You should do pull to get the latest. Also run yarn install to pick up library upgrades.

Thanks for the help. I think I see what you did here by mocking the child components to isolate just testing the PhotoMontage. I'll make sure I do this in the future!

[vnugent]

Thank you for taking on this. Some feedback:

1. Area texts are hard to read. Maybe use the default black text and set the background similar to how it's previously done in the user gallery? (Neat and Cool tag)

2. It may be a bit cluttering to have full username next to tags . Can you use the person icon? or does it make sense to reuse the RecentMediaCard so the gallery look consistent/similar to the front page?

---

[clintonlunn]

@vnugent I agree they are hard to read?

I tested out putting the recent media cards into the photogallery. What do you think of this? I feel like we might want to put some kind of border around to separate each card. I also feel that way about the newTags page too, but would also defer to what you think

[vnugent]

@vnugent I agree they are hard to read?

I tested out putting the recent media cards into the photogallery. What do you think of this? I feel like we might want to put some kind of border around to separate each card. I also feel that way about the newTags page too, but would also defer to what you think

I like the newer version. Instead of adding borders, what about increasing the spacing between the cards?

I also feel that way about the newTags page too

which tag page? the user profile?

[clintonlunn]

@vnugent what do you think about this?

[vnugent]

Can you please rebase? Not sure why photos are not loading in the preview build. We recently switched to the new image resizing service and introduced a PR that improves the way we load images.

[vnugent]

Visually these cards are very similar to RecentMedia cards. Let's merge after you rebase and refactor later.

[vnugent]

Superceded by PR #1012