Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the header for naviage to map #1189

Closed
wants to merge 3 commits into from

Conversation

AQIB-NAWAB
Copy link


name: Pull request
about: Create a pull request
title: add hero alert for "Find Climbings by State " at home page
labels: ''
assignees: ''


What type of PR is this?(check all applicable)

  • [ x] optimization

Description

Add the header for naviage to map

Related Issues

Issue # #1177

What this PR achieves

Add a button to navigate the page to search the locations by state

Screenshots, recordings

image

Copy link

vercel bot commented Oct 28, 2024

@AQIB-NAWAB is attempting to deploy a commit to the openbeta-dev Team on Vercel.

A member of the Team first needs to authorize it.

@AQIB-NAWAB
Copy link
Author

fix #1177

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
open-tacos ✅ Ready (Inspect) Visit Preview Oct 31, 2024 6:01pm

Copy link
Collaborator

@clintonlunn clintonlunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AQIB-NAWAB it looks like you've still got those linting errors.

Can you run yarn run lint in your local terminal on this branch and fix those warnings? No need to create another pr, we can squash the changes when merging.

@clintonlunn
Copy link
Collaborator

@vnugent would you mind approving the vercel deploy for this?

@AQIB-NAWAB
Copy link
Author

@clintonlunn Oops forgot to run that command , Just resolved the linting errors
You can review it now

@clintonlunn
Copy link
Collaborator

Hi @AQIB-NAWAB i added a few comments. In addition can you pull in the latest changes. You'll see that LandingHero.tsx changed recently in this pr https://github.com/OpenBeta/open-tacos/pull/1195/files#diff-f2977183e5d7a5b514e34954a79abf75e822bf3c313b39c9e4f9bb9a2f55fe89

I think it's fine to add the HeroAlert back but account for a variable number of HeroAlerts

@vnugent
Copy link
Contributor

vnugent commented Nov 18, 2024

Superseded by PR #1196

@vnugent vnugent closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants