Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libraries : add sunset/sunrise time #244

Closed
wants to merge 3 commits into from
Closed

Libraries : add sunset/sunrise time #244

wants to merge 3 commits into from

Conversation

RuffaloLavoisier
Copy link
Member

This is a draft for sunrise/sunset composition.
See : #207

@RuffaloLavoisier RuffaloLavoisier added the ⭐ enhancement New feature or request label Jun 15, 2022
@RuffaloLavoisier RuffaloLavoisier requested a review from a team June 15, 2022 15:01
@RuffaloLavoisier RuffaloLavoisier self-assigned this Jun 15, 2022
@RuffaloLavoisier RuffaloLavoisier marked this pull request as draft June 15, 2022 15:01
simonmicro
simonmicro reviewed Jun 15, 2022
View reviewed changes
Copy link
Member

@simonmicro simonmicro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just added the lib. Fine. I mean, could you do anything with it? E.g. add it to a watchface, extend the HAL interface - anything? Otherwise the PR is fine, but sort of useless 😅

@RuffaloLavoisier
Copy link
Member Author

@simonmicro
Just make sure the things I added are correct I'm going to add an example after that.

@RuffaloLavoisier RuffaloLavoisier force-pushed the RuffaloSunset branch 2 times, most recently from 9036407 to 4d91258 Compare June 16, 2022 01:19
@RuffaloLavoisier
Copy link
Member Author

Well, I personally think that this library is not useful. close it.

@RuffaloLavoisier RuffaloLavoisier deleted the RuffaloSunset branch June 16, 2022 02:14
@RuffaloLavoisier RuffaloLavoisier removed the ⭐ enhancement New feature or request label Jun 16, 2022
@RuffaloLavoisier RuffaloLavoisier removed their assignment Jun 16, 2022
@simonmicro simonmicro added the ⭐ enhancement New feature or request label Jun 16, 2022
@simonmicro
Copy link
Member

Please keep the labels of the closed PRs @RuffaloLavoisier , this way we can filter more quickly what was done where.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonmicro simonmicro simonmicro left review comments

Assignees

@RuffaloLavoisier RuffaloLavoisier

Labels
⭐ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RuffaloLavoisier @simonmicro