Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 3rd definable icon size and fix precompiled header paths #2097

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Olive6841
Copy link

  • Changed #include <stdafx.h> to #include "stdafx.h"
  • Add a 3rd definable "medium" icon size which is 24x24px by default on 96DPI

Olive6841 and others added 4 commits December 22, 2024 13:15
Adds a 3rd custom "Medium" icon size which is 24x24 by default, but can be adjusted via the settings GUI
I am guessing that at one time, an update to MSVC (not sure exactly) removed stdafx from being a standard header therefore requiring <stdafx.h> to be replaced with "stdafx.h"
@AppVeyorBot
Copy link

Build Open-Shell-Menu 4.4.196-svwixqlx completed (commit 821ed99ab0 by @Olive6841)

@ge0rdi
Copy link
Member

ge0rdi commented Jan 10, 2025

Changed #include <stdafx.h> to #include "stdafx.h"

There is certainly no need for this change.
Code should build just fine with that,

What problem did you encounter?
Do you have latest VS 2022? What project/configuration were you building?

@ge0rdi
Copy link
Member

ge0rdi commented Jan 10, 2025

Add a 3rd definable "medium" icon size which is 24x24px by default on 96DPI

Can you expand a bit more about the motivation for adding this?
Where would that medium size used?

@Olive6841
Copy link
Author

Add a 3rd definable "medium" icon size which is 24x24px by default on 96DPI

Can you expand a bit more about the motivation for adding this? Where would that medium size used?

It would be able to be used in the .skin file
For example setting the Main2 icon size to 24x24px while keeping Main icon size as 32x32px or vise versa allows for more mixing and matching

@Olive6841
Copy link
Author

Olive6841 commented Jan 10, 2025

Screenshot_20250110_074953_Firefox

Changed #include <stdafx.h> to #include "stdafx.h"

There is certainly no need for this change. Code should build just fine with that,

What problem did you encounter? Do you have latest VS 2022? What project/configuration were you building?

It more for consistency sake rather than issues compiling, openshell currently has about half <stdafx.h> and half "stdafx.h" so i just moved them all to the second one

@AppVeyorBot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants