-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update MSUI Help Section #2613
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is also not good to add your e-mail address there, this gives some more spam.
When you use as in the old example John Doe, it is constistant with what happens in the chat using this user. And the other users are also in the other pngs.
Just seen it is draft, sorry, I was looking already. |
That's alright! Thank you for the review. I'll make the necessary changes. |
it looks like ui_mscolab_help_dialog.py was edited manually. In case you did, there are linting failures which usually is avoided by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the name upload-profile is a bit misleading it is more like add-profile-image
you do describe the action
while looking on the chat picture again now I realized, that the role admin is a bit too often there. creator can give admin role to someone to add users with roles. commonly we have more with the collaborator role than with admin. |
Fixes #2600
Purpose of PR?:
Added Tab in the Help section of MSUI which will have instructions on how to upload a profile picture.
Updated the chat window which now shows profile photo and
online indicator feature.