Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update MSUI Help Section #2613

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

divyaajainn
Copy link
Contributor

@divyaajainn divyaajainn commented Jan 27, 2025

Fixes #2600

Purpose of PR?:

  1. Added Tab in the Help section of MSUI which will have instructions on how to upload a profile picture.
    profile tab

  2. Updated the chat window which now shows profile photo and
    online indicator feature.
    new chat window

@divyaajainn divyaajainn marked this pull request as draft January 27, 2025 17:52
Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use similiar to the old images, names which we like to see by a user.

in the previous example, we had also a meaningful conversation.

image

Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is also not good to add your e-mail address there, this gives some more spam.

When you use as in the old example John Doe, it is constistant with what happens in the chat using this user. And the other users are also in the other pngs.

@ReimarBauer
Copy link
Member

Just seen it is draft, sorry, I was looking already.

@divyaajainn
Copy link
Contributor Author

That's alright! Thank you for the review. I'll make the necessary changes.

@divyaajainn divyaajainn marked this pull request as ready for review January 29, 2025 10:19
@ReimarBauer
Copy link
Member

it looks like ui_mscolab_help_dialog.py was edited manually. In case you did, there are linting failures which usually is avoided by pyuic5 --from-imports

Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name upload-profile is a bit misleading it is more like add-profile-image
you do describe the action

@ReimarBauer
Copy link
Member

while looking on the chat picture again now I realized, that the role admin is a bit too often there. creator can give admin role to someone to add users with roles. commonly we have more with the collaborator role than with admin.
admin role has also all collaborator options. So it is not wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve/Update MSUI Help Section
2 participants