Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codespell: Add EMAC and fix 'lins' #2607

Merged
merged 6 commits into from
Jan 26, 2025

Conversation

annapurna-gupta
Copy link
Contributor

Fixes #2599

@ReimarBauer ReimarBauer changed the base branch from develop to stable January 24, 2025 16:34
@ReimarBauer
Copy link
Member

I changed the base to stable.

Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EMAC fix is missing.

@annapurna-gupta
Copy link
Contributor Author

The EMAC fix is missing.

I added 'EMAC' to codespell-ignored-lines.txt, but codespell still flags it. I tried using the --ignore-words flag, but it didn't work

@ReimarBauer
Copy link
Member

There is only 1 file in this commit. Where do you have added it?

@annapurna-gupta
Copy link
Contributor Author

There is only 1 file in this commit. Where do you have added it?

now you can see it.

@ReimarBauer
Copy link
Member

Have you missed to add this file?

https://github.com/Open-MSS/MSS/blob/develop/codespell-ignored-lines.txt

@annapurna-gupta
Copy link
Contributor Author

annapurna-gupta commented Jan 24, 2025

Have you missed to add this file?

https://github.com/Open-MSS/MSS/blob/develop/codespell-ignored-lines.txt

No, the file is present, and I have made changes to it.

@ReimarBauer
Copy link
Member

Maybe read the documentation https://github.com/codespell-project/codespell

for setting up words to become excluded.

@annapurna-gupta
Copy link
Contributor Author

Maybe read the documentation https://github.com/codespell-project/codespell

for setting up words to become excluded.

This helped, thank you!

@ReimarBauer
Copy link
Member

ignore coverage, that is a bit random, but don't ignore the linters.

@annapurna-gupta
Copy link
Contributor Author

ignore coverage, that is a bit random, but don't ignore the linters.

okk

Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@ReimarBauer ReimarBauer merged commit 06d860e into Open-MSS:stable Jan 26, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new codespell findings
2 participants