Fixed bug where visualization shape is reset when navigating.

[wolfmanstout]

Fixes #870

[lentinj]

Thanks for finding this! Yes this makes a lot more sense now.

FWIW, I think the bug is really here:

OZtree/OZprivate/rawJS/OZTreeModule/src/navigation/setup_page.js

Lines 10 to 24 in 889026e

	function setup_page_by_state(controller, state) {
	var init = !tree_state.url_parsed;
	if (state.hasOwnProperty('image_source')) controller.set_image_source(state.image_source, init)
	if (state.hasOwnProperty('lang')) controller.set_language(state.lang, init)
	if (state.hasOwnProperty('search_jump_mode')) controller.set_search_jump_mode(state.search_jump_mode, init)
	if (state.hasOwnProperty('title')) document.title = unescape(state.title);
	if (state.hasOwnProperty('home_ott_id')) config.home_ott_id = state.home_ott_id || null;
	if (state.hasOwnProperty('ssaver_inactive_duration_seconds')) tree_settings.ssaver_inactive_duration_seconds = state.ssaver_inactive_duration_seconds || tree_settings.default.ssaver_inactive_duration_seconds
	if (state.hasOwnProperty('cols')) controller.change_color_theme(state.cols, init)
	controller.close_all();
	// Change view type
	// NB: In doing so, we implicitly rebuild the tree, which needs to happen regardless on init
	return controller.change_view_type(state.vis_type, init).then(function () {

Note everything else only calls the appropriate change function only when there's a value to fill in. change_view_type() we do regardless, to rebuild the tree as a side-effect.

We could do something like ( init || state.hasOwnProperty('vis_type') ? controller.change_view_type(state.vis_type, init) : Promise.resolve() ), but up to you. Happy to merge this as-is too.

Really we shouldn't be relying on change_view_type to rebuild the tree anyway, but unpicking that isn't for today. I seem to have attempted this in the past and it went wrong...

[wolfmanstout]

Updated the fix per your suggestion (and tested it).

[lentinj]

Excellent. Thanks!