Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ada support conway #376
base: onekey
Are you sure you want to change the base?
feat: ada support conway #376
Changes from all commits
f800200
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
避免修改函数参数
在
transformDelegation
函数中,直接修改了传入的delegation
对象。为避免副作用,建议创建新的对象来处理参数转换。建议修改如下:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
避免修改函数参数
同样地,在
transformCvoteRegistrationParameters
函数中,直接修改了传入的cVoteRegistrationParameters
对象。建议使用新的对象来处理,避免对原始参数的修改。建议修改如下:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
检查 'paymentAddressParameters' 是否为 undefined
在调用
validateAddressParameters(paymentAddressParameters)
之前,应该检查paymentAddressParameters
是否为 undefined,以防止可能的错误。建议修改如下:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议处理未知的
dRep.type
当前的
transformDRep
函数只处理了KEY_HASH
和SCRIPT_HASH
类型。如果出现未知的dRep.type
,函数可能返回未定义的key_hash
和script_hash
,可能导致意外行为。建议添加错误处理,以捕获未知的dRep.type
,提高代码的健壮性。可以考虑以下修改:
📝 Committable suggestion