sync upstream #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I first implemented this feature, I assumed the `has_associated_audits` enabled auditing of the parent model and connected the child audits. When I tested the `company.own_and_associated_audits` I got an `undefined method `own_and_associated_audits'`. It took me a while to guess that I needed to also added audited to the parent model. I think adding the `audited` to the parent will make the docs more explicit and devs will immediately realized that `has_associated_audits` is a extra/separate call.
When combining audits the oldest remaining audit is updated and the audits over max_audit count are deleted. This can result in a deadlock if if the same record is updated at the same time. However by virtue of being at the same time the same end is being selected and the same verion number is used for the delete. This means the same update and same delete are being performed for both audit combinations so this error can just be ignored.
Test against Rails 7.0 stable
I want to improve how we do this, but this gets more things passing in the interim.
Trying to get tests back to passing.
It is segfaulting on GitHub Actions and I don't care enough to fix it right now.
Should effectively be the same query but easier to read and with the benefit of ActiveRecord's type casting and association reflection. Fixes issue dealing with mutiple id column types
Replace raw string where clause with query methods
…after-block-fix Ensure audits are re-enabled after blocks
Use string class name and constantize
…igrations-deprecation Fix timestamped_migrations deprecation warning
…attributes-automatically Filter encrypted attributes automatically
…bine_deadlock Deadlocks from concurrent audit combinations
Add audited method to parent in docs
Add support for Rails 7.1
…urrent_attributes Replace RequestStore with `ActiveSupport::CurrentAttributes`
…al-require-railtie Conditional require railtie to support using audited gem in non-Rails projects
This reverts commit f8416b1.
mshimizu-oc
force-pushed
the
misc/sync-upstream
branch
from
1b3aa77 to
3f6359c
Compare
mshimizu-oc
force-pushed
the
misc/sync-upstream
branch
from
3f6359c to
dd4a7de
Compare
mshimizu-oc
force-pushed
the
misc/sync-upstream
branch
from
435ca27 to
fc05a40
Compare
reez12g
approved these changes
Dec 15, 2023
trafico-bot
bot
added
✅ Approved
dkyoyoung
approved these changes
Dec 18, 2023
trafico-bot
bot
added
✨ Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync https://github.com/collectiveidea/audited/releases/tag/v5.4.2
github workflowは消されていましたが、テストが無いと不安な気がしたので改めて追加しました。
set_sqlのテストはサラッと書いてみたらうまくいかなかったので、今回は追加を諦めました。
（おそらく事前準備が足りて無い）