[feat]: 회원가입 유효성 검증 추가, 닉네임 처리 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| @@ -96,10 +98,12 @@ public void deleteInactiveUsers() { | |||
| } | |||
| @Transactional | |||
| public void deleteInactiveUsersTest() { | |||
There was a problem hiding this comment.
deleteInactiveUsers와 필터링 날짜만 다르고 같은 기능으로 테스트용으로 만들어놨습니다! 지금은 UserController의 hardDeleteTest에서 호출할 때 동작합니다
kimjm9841
approved these changes
Feb 13, 2024
| private AdditionalInfo additionalInfo; | ||
| } | ||
|
|
||
| @Getter | ||
| public static class AdditionalInfo{ | ||
| @NotNull | ||
| @NotBlank | ||
| private String nickname; |
There was a problem hiding this comment.
닉네임도 최대 사이즈 제한 있어야 할 거 같아용
realisshomyang
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
@scheduled annotation으로 실제로 서버에서 하루 주기로 확인해서 지우는 함수 나중에 추가하면 좋을 것 같아요!
저번에 회원 탈퇴 맡았을 때 작성했었는데 날아가버린 .. ㅜ
|
엇 그거는 남겨 두고 저거 추가적으로 테스트 때문에 작성한거에요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
🎋 작업중인 브랜치
💡 작업동기
🔑 주요 변경사항
💡 관련 이슈
x