Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat]: 회원가입 로직 수정 #55

Merged
merged 7 commits into from
Feb 4, 2024
Merged

[feat]: 회원가입 로직 수정 #55

merged 7 commits into from
Feb 4, 2024

Conversation

wu-seong
Copy link
Contributor

@wu-seong wu-seong commented Feb 4, 2024

PULL REQUEST

🎋 작업중인 브랜치

💡 작업동기

  • 회원가입 로직을 하나의 API 처리하기 위해서

🔑 주요 변경사항

  • 업무분야, 연차 EnumType 생성 및 조회 API 추가
  • 토큰 검증 API에 추가정보 같이 받아서 성공 시 한번에 저장
  • 요청 enum 값 유효하지 않을 시에 예외 처리

💡 관련 이슈

x

@wu-seong wu-seong linked an issue Feb 4, 2024 that may be closed by this pull request
[feat]: 유저 회원가입 로직 수정 #54
Closed
3 tasks
@wu-seong wu-seong self-assigned this Feb 4, 2024
@wu-seong wu-seong added the ✨ feat 새로운 기능 추가 label Feb 4, 2024
realisshomyang
realisshomyang approved these changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@realisshomyang realisshomyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

threeony
threeony approved these changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@threeony threeony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~!

kimjm9841
kimjm9841 approved these changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@kimjm9841 kimjm9841 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~! 혹시 업무분야 데이터 검증은 어디서 하나용?

@wu-seong
Copy link
Contributor Author

wu-seong commented Feb 4, 2024 •
edited
Loading

수고하셨습니다~! 혹시 업무분야 데이터 검증은 어디서 하나용?

엇.. 그것도 추가해야겠네요 수정해서 다시 올리겠습니다

@wu-seong wu-seong merged commit d5d233c into dev Feb 4, 2024
@wu-seong wu-seong deleted the feat/#54 branch February 4, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threeony threeony threeony approved these changes

@realisshomyang realisshomyang realisshomyang approved these changes

@kimjm9841 kimjm9841 kimjm9841 approved these changes

Assignees

@wu-seong wu-seong

Labels
✨ feat 새로운 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat]: 유저 회원가입 로직 수정
4 participants
@wu-seong @kimjm9841 @realisshomyang @threeony