Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor]: on API 수정 #45

Merged
merged 3 commits into from
Feb 3, 2024
Merged

[refactor]: on API 수정 #45

merged 3 commits into from
Feb 3, 2024

Conversation

threeony
Copy link
Contributor

@threeony threeony commented Feb 2, 2024

PULL REQUEST

🎋 작업중인 브랜치

💡 작업동기

  • on API 수정

🔑 주요 변경사항

  • 오늘의 다짐 Repository 순서 기준 정렬 추가
  • 업무일지 Repository createdAt 기준 정렬 추가
  • 미래 다짐 / 일지 작성 불가 어노테이션 추가
  • 수정 시 response null -> DTO
  • userId로 찾아오기 -> getUser 사용

💡 관련 이슈

  • 관련 이슈를 입력해주세요.

@threeony threeony added the ♻️ refactor 코드 리팩토링 label Feb 2, 2024
@threeony threeony self-assigned this Feb 2, 2024
@threeony threeony linked an issue Feb 2, 2024 that may be closed by this pull request
[refactor]: on API 수정 #38
Closed
5 tasks
kimjm9841
kimjm9841 approved these changes Feb 3, 2024
View reviewed changes
Copy link
Contributor

@kimjm9841 kimjm9841 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!

@threeony threeony merged commit 87b6a0f into dev Feb 3, 2024
@threeony threeony deleted the refactor/#38 branch February 3, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimjm9841 kimjm9841 kimjm9841 approved these changes

Assignees

@threeony threeony

Labels
♻️ refactor 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[refactor]: on API 수정
2 participants
@threeony @kimjm9841