[feat]: 회고 관련 API 수정 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimjm9841
added
✨ feat
Closed
9 tasks
wu-seong
reviewed
Feb 2, 2024
| import java.util.Optional; | ||
|
|
||
| public interface MemoirRepository extends JpaRepository<Memoir, Long> { | ||
|
|
||
| Optional<Memoir> findByUserAndDate(User user, LocalDate date); | ||
|
|
||
| List<Memoir> findByUserAndIsBookmarkedOrderByDateDesc(User user, Boolean isBookmarked); | ||
| } |
There was a problem hiding this comment.
생각해보니까 북마크 부분은 페이징 안해도 되려나?
There was a problem hiding this comment.
그러게.. 페이징 필요할 거 같아서 수정하고 커밋할게용
wu-seong
approved these changes
Feb 2, 2024
realisshomyang
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
@threeony 코드에서는 Handler 만들어서 던지는데 지민님 코드에서는 다른 것 같아요 통일하는게 좋을듯?
| Memoir newMemoir = MemoirConverter.toMemoir(request); | ||
| Memoir newMemoir = Memoir.builder() | ||
| .date(request.getDate()) | ||
| .emoticon(emoticonRepository.findById(request.getEmoticonId()).orElseThrow(() -> new GeneralException(ErrorStatus.EMOTICON_NOT_FOUND))) |
There was a problem hiding this comment.
여기 Handler call하는거 아니였남?? apiPayload -> handler -> Handler
exception (통일하면 좋을 것 같은데)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
🎋 작업중인 브랜치
💡 작업동기
🔑 주요 변경사항
💡 관련 이슈