[feat]: 푸시알람 구현 #39
Merged
[feat]: 푸시알람 구현 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
wu-seong
approved these changes
Jan 31, 2024
| for (User user : userList) { | ||
| NotificationMessage notificationMessage = NotificationMessage.toGoHomeNotification(user); | ||
| Message message = fcmService.createMessage(user.getFcmToken(), notificationMessage); | ||
| fcmService.send(message); |
There was a problem hiding this comment.
궁금해서 그런데 여기서 가져온 fcmToken은 푸시 알림 동의 했을때 set 되는건가요??
There was a problem hiding this comment.
네 온보딩에서 푸시 알람 동의했을 때 프론트 측에서 한 번에 유저 정보 업데이트 api 요청할 때 담아서 보내주고, 이를 기반으로 백이 디비에 업데이트 하는 식으로 로직 이해하고 있습니다 ~
kimjm9841
reviewed
Feb 1, 2024
| ) { | ||
| public static NotificationMessage toGoHomeNotification(User user) { | ||
| return NotificationMessage.builder() | ||
| .title(user.getName() + "님, 이제 퇴근하실 시간이에요.") |
There was a problem hiding this comment.
별 건 아니지만 WF 보면 다 닉네임으로 부르길래 여기도 name 대신 nickname 쓰는 게 더 좋지 않을까 싶어용
There was a problem hiding this comment.
넵 수정 후 커밋할게요!
|
Merge할게요 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
🎋 작업중인 브랜치
💡 작업동기
🔑 주요 변경사항
💡 관련 이슈