Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add finite consolidation approvals, support cross clearing house consolidation #3224

Merged
merged 8 commits into from
Dec 23, 2024
Merged

add finite consolidation approvals, support cross clearing house consolidation #3224

merged 8 commits into from
Dec 23, 2024

Conversation

brightiron
Copy link
Contributor

@brightiron brightiron commented Oct 15, 2024 •
edited
Loading

Resolves #3217

Blocked by new consolidation contract deployment

  • Updates useApproveToken hook to add an optional spendAmount slot
  • uses collateral and debt values from consolidation contract and passes them to tokenAllowanceGuard
  • Re-enables disabled consolidation code

TODO

  • Add address of new LoanConsolidator contract
  • Wait for proposal approval/activation before deployment

image
image

UX if user has positions in multiple clearinghouses:
image
image

0xJem
0xJem approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@0xJem 0xJem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/abi/CoolerConsolidation.json Show resolved Hide resolved
@brightiron brightiron mentioned this pull request Oct 23, 2024
Closed
@brightiron brightiron changed the title add finite consolidation approvals add finite consolidation approvals, support cross clearing house consolidation Dec 19, 2024
@brightiron brightiron marked this pull request as ready for review December 21, 2024 15:13
@brightiron brightiron merged commit 7a4df8d into develop Dec 23, 2024
4 of 6 checks passed
@brightiron brightiron deleted the finiteCoolerApprovals branch December 23, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xJem 0xJem 0xJem approved these changes

Assignees

@brightiron brightiron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement finite approvals for CoolerUtils
2 participants
@brightiron @0xJem