Remove unused env vars. update readme. Deploy your own frontend. #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brightiron
commented
Dec 22, 2023
brightiron
commented
- If no env var set for protocol metrics hide protocol metrics
- remove unused env vars
- update readme
- one click deploy buttons for convenience.
unbanksy
requested changes
Dec 28, 2023
| VITE_GIVE_ENABLED="true" | ||
| # This should be toggled to "true" if you need to use the mock sOHM contract | ||
| # (which allows for on-demand rebasing) | ||
| VITE_MOCK_SOHM_ENABLED="false" | ||
|
|
||
| # Optional | ||
| # Google Analytics (https://analytics.google.com/) | ||
| VITE_GOOGLE_ANALYTICS_API_KEY="" |
| @@ -25,14 +17,6 @@ VITE_FANTOM_TESTNET_NODE_URL="" | |||
| VITE_POLYGON_NODE_URL="" | |||
| VITE_POLYGON_TESTNET_NODE_URL="" | |||
| @@ -41,4 +25,7 @@ VITE_AVALANCHE_NODE_URL="" | |||
| VITE_AVALANCHE_TESTNET_NODE_URL="" | |||
There was a problem hiding this comment.
Same question here. Why do we need this in code?
There was a problem hiding this comment.
can probably remove these and only support mainnet and arbitrum on the network selector.
| @@ -202,6 +203,8 @@ function App() { | |||
| if (isSidebarExpanded) handleSidebarClose(); | |||
| }, [location]); | |||
|
|
|||
| const protocolMetricsEnabled = Boolean(Environment.getWundergraphNodeUrl()); | |||
| const defaultRoute = protocolMetricsEnabled ? "/dashboard" : "/my-balances"; | |||
There was a problem hiding this comment.
Can we just make the default route always be /my-balances?
There was a problem hiding this comment.
yes. just hadn't historically. so didn't wanna break functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.