Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My Balances #3018

Merged
merged 21 commits into from
Nov 22, 2023
Merged

My Balances #3018

merged 21 commits into from
Nov 22, 2023

Conversation

brightiron
Copy link
Contributor

@brightiron brightiron commented Nov 2, 2023 •
edited
Loading

Todo:

  • move actions into modals instead of full page views.
  • check disconnected state
  • check cross chain state
  • check mobile

@brightiron brightiron changed the title [WIP] - My Balances My Balances Nov 7, 2023
@brightiron brightiron marked this pull request as ready for review November 7, 2023 00:51
unbanksy
unbanksy approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@unbanksy unbanksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Left a minor request to re-order information on RBS page.

src/views/Lending/Cooler/hooks/useGetCoolerBalance.tsx Outdated Show resolved Hide resolved
src/views/Lending/Cooler/hooks/useGetCoolerBalance.tsx Show resolved Hide resolved
src/views/Range/index.tsx Outdated Show resolved Hide resolved
@brightiron brightiron merged commit aee1d60 into develop Nov 22, 2023
5 of 6 checks passed
@brightiron brightiron deleted the stakingPage branch November 22, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unbanksy unbanksy unbanksy approved these changes

@appleseed-iii appleseed-iii Awaiting requested review from appleseed-iii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brightiron @unbanksy