Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for LLVM 18 compatibility and CI #44

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Fix for LLVM 18 compatibility and CI #44

merged 4 commits into from
Dec 4, 2024

Conversation

ggeorgakoudis
Copy link
Collaborator

  • Changes for compatibility with LLVM 18 and LLVM 17
  • Cleanup cmake files
  • CI for LLVM 18 through rocm 6.2.1

@ggeorgakoudis @tbennun
Fix for LLVM 18 compatibility and CI
1eaec8a 
- Changes for compatibility with LLVM 18 and LLVM 17
- Cleanup cmake files
- CI for LLVM 18 through rocm 6.2.1

---------

Co-authored-by: Tal Ben-Nun <[email protected]>
koparasy
koparasy requested changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@koparasy koparasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some are minor. Overall I think the pass would benefit by heaving some clear methods in ProteusJitPassImpl that show the interface to the runtime system. It will make it easier to read.

@ggeorgakoudis
Copy link
Collaborator Author

Note: The CI tests on tioga will be failing for 6.2.1 and this is expected

tbennun
tbennun approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggeorgakoudis ggeorgakoudis mentioned this pull request Dec 4, 2024
Closed
@ggeorgakoudis ggeorgakoudis merged commit 189097c into main Dec 4, 2024
10 of 12 checks passed
@ggeorgakoudis ggeorgakoudis deleted the fix-for-llvm18 branch December 4, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

@koparasy koparasy koparasy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggeorgakoudis @koparasy @tbennun