Skip to content

Commit

Permalink
using devcontainer common utils
Browse files Browse the repository at this point in the history
  • Loading branch information
OliverKillane committed Sep 28, 2023
1 parent d11ecd8 commit e507e3f
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 9 deletions.
6 changes: 3 additions & 3 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ubuntu:latest
FROM debian:bookworm-slim


# Install basic packages
Expand All @@ -22,8 +22,8 @@ RUN tlmgr update --self --all
RUN tlmgr install latexindent chktex

# install inkscape (for tikz) and minted (for code highlighting)
RUN apt-get install -qy inkscape python3 python3-pip
RUN pip install pygments
RUN apt-get install -qy inkscape python3 python3-pip pipx
RUN pipx install pygments

# C++
# Already installed GCC as part of build-essential
Expand Down
5 changes: 5 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"image": "ghcr.io/oliverkillane/imperial-computing-notes-dev",
"features": {
"ghcr.io/devcontainers/features/common-utils:2": {
"version": "latest"
}
},
"customizations": {
"vscode": {
"settings": {
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/push-dev-image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,17 @@ on:
branches:
- enh/development-docker
paths:
- '.devcontainer/**'
- '.devcontainer/Dockerfile'

jobs:
docker:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
with:
sparse-checkout: .devcontainer/Dockerfile
sparse-checkout-cone-mode: false
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Enrich Metadata
Expand Down
5 changes: 0 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,3 @@ It is designed as an improvement in quality over the [second year repo](https://
## How do I build this?

## [I want to contribute!](./.github/CONTRIBUTING.md)
## I've found a mistake!
Simply [add a new issue](https://github.com/OliverKillane/Imperial-Computing-Year-3-Notes/issues/new/choose) and attach the relevant labels.

![Screenshot 2022-10-09 015053](https://user-images.githubusercontent.com/44177991/194732526-54cca108-9fa7-4b0e-a4af-b0baad625af9.png)

0 comments on commit e507e3f

Please sign in to comment.