Feature/bookmarks #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to add all the bookmarks in one place, created link and route /bookmarks in Header
Created a Bookmark Context: To manage shared bookmark state across components. Wrapped Application: Made the context available throughout the application. Updated Components: Modified BookmarksPage, HomePage, and ResourceList to utilise the context for managing bookmarks. Made a Commit: Saved and documented your changes.
Added authorisation error handling to display an appropriate message on the screen if the user is not logged in.
|
Could you update the base of this PR to target the upstream branch, |
|
Thank you @OlhaDanylevska for your great design for the bookmark. However, I faced an issue on the page, and the bookmark feature is not functioning properly.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a:
Description
Merging this pull request will implement a new bookmark feature for resources. Authorised users will see bookmark icons on resource cards in the resource list. They can bookmark resources to highlight them for quick access. Bookmarked resources will also appear on a dedicated bookmarks page, accessible via a "Bookmarks" button in the navigation menu. Users can toggle bookmarks directly from the home page or the bookmarks page, with changes immediately updating in the database. This feature enhances user experience by enabling personalised resource management.
-The purpose of this pull request is to enhance the user experience by implementing a bookmark feature. It allows authorised users to easily manage and access their preferred resources. This includes highlighting resources for quick reference and consolidating them on a dedicated bookmarks page.
Bookmark Icon Functionality:
Navigate to the resource list page as an authorised user.
-Verify that bookmark icons are displayed on resource cards if user logged in
-Test toggling the bookmark state (adding and removing bookmarks).
-Confirm that the changes persist by refreshing the page.
Bookmarks Page:
-Navigate to the "Bookmarks" page via the button in the navigation menu.
-Verify that all bookmarked resources appear on the page.
-Test toggling bookmarks directly from this page.
Database Updates:
-Confirm that the bookmark toggles immediately update the database by checking the database entries for the user.
How to check -
Links
Author checklist
mainfrom a branch named<category>/<name>, e.g.feature/edit-spaceshipsorbugfix/restore-oxygen