Spond.get_messages: add max_chats parameter (default 100) and populate Spond.messages.
#146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliot-100
changed the title
Spond.get_messages: add max_chats parameter and populate Spond.messages.Spond.get_messages: add max_chats parameter (default 100) and populate Spond.messages.
elliot-100
force-pushed
the
144-allow-spondget_messages-to-get-more-than-10-messages-1
branch
2 times, most recently
from
ce5d441 to
c1d3af5
Compare
elliot-100
force-pushed
the
144-allow-spondget_messages-to-get-more-than-10-messages-1
branch
from
c1d3af5 to
4f9a826
Compare
|
Looks fine by reading through it. Have not tested it in real life |
|
Thanks @Olen. I have tested it with Edit: reworked |
elliot-100
deleted the
144-allow-spondget_messages-to-get-more-than-10-messages-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Spond.get_messagesto get more than 10 messages. #144: Adds an optionalmax_chatsparameter toSpond.get_messages(); defaults to 100. Previously up to 10 chats were returned.Spond.get_messages()doesn't populateSpond.messages#145: #ChangesSpond.get_messages()so it populatesSpond.messagesin line with otherget_{multiple_items_from_api}()methods.manual_test_functionsto use the new parameter (and extracts allmaxvalues to constants)