comments

OilerNetwork · Oct 7, 2024 · c4d3ac0 · c4d3ac0
1 parent 1afdbfa
commit c4d3ac0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/tests/option_round/state_transition/fulfill_request_tests.cairo b/src/tests/option_round/state_transition/fulfill_request_tests.cairo
@@ -180,3 +180,5 @@ fn test_fulfilling_multiple_request() {
         }
 }
 
+// @note todo add test for request timestamp out of bounds (high and low for both fulfillment types (auction start/round settle))
+// @note todo add test for setting default values then starting auction/settling round
diff --git a/src/vault/contract.cairo b/src/vault/contract.cairo
@@ -591,10 +591,6 @@ mod Vault {
             // address to fulfill requests, eventually update to proof verification instead
             let caller = get_caller_address();
             assert(self.fulfillment_whitelist.entry(caller).read(), Errors::CallerNotWhitelisted);
-            //            if self.fulfillment_whitelist.entry(caller).read() == false {
-            //                // emit event ?
-            //                return false;
-            //            }
 
             // @dev If the current round is Open, set its pricing data directly
             if state == OptionRoundState::Open {
-Original file line number
+Diff line change
@@ Expand Up / @@ -180,3 +180,5 @@ fn test_fulfilling_multiple_request() { @@
             }
     }
+    // @note todo add test for request timestamp out of bounds (high and low for both fulfillment types (auction start/round settle))
+    // @note todo add test for setting default values then starting auction/settling round