Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retries for proofs and starknet #14

Merged
merged 6 commits into from
Jan 8, 2025
Merged

Conversation

ametel01
Copy link
Collaborator

@ametel01 ametel01 commented Jan 7, 2025

No description provided.

Add new MMR build options:
- Add --start-block (-s) to start building from specific block
- Add --from-latest (-l) to start from latest MMR block
- Add validation to prevent conflicting options
- Update help text for all CLI options

Refactor RPC URL handling:
- Move RPC URL handling from StarknetAccount to AccumulatorBuilder
- Add starknet_rpc_url field to AccumulatorBuilder struct
- Update AccumulatorBuilder::new signature to accept RPC URL
- Remove RPC URL handling from StarknetAccount

New AccumulatorBuilder methods:
- Add build_from_block for starting from specific block
- Add build_from_latest for starting from latest MMR block
- Add build_from_block_with_batches for batch processing
- Add build_from_latest_with_batches for batch processing

This change improves flexibility in MMR building by:
1. Allowing users to specify custom start points
2. Supporting continuation from latest MMR state
3. Making the RPC URL dependency explicit
4. Simplifying provider creation for latest block queries
@ametel01 ametel01 merged commit 90dd9ab into main Jan 8, 2025
2 checks passed
@ametel01 ametel01 deleted the retries-for-proofs-and-starknet branch January 8, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant