Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add unit tests for components #26

Merged
merged 7 commits into from
Jan 16, 2025
Merged

tests: add unit tests for components #26

merged 7 commits into from
Jan 16, 2025

Conversation

cwkang1998
Copy link
Collaborator

No description provided.

Base automatically changed from feat/quick-index to sepolia-db January 15, 2025 05:48
@cwkang1998 cwkang1998 force-pushed the test/add-unit-tests-for-components branch from 8c98212 to 2161e57 Compare January 15, 2025 06:12
@cwkang1998 cwkang1998 force-pushed the test/add-unit-tests-for-components branch from 2161e57 to 65baa63 Compare January 15, 2025 13:40
@cwkang1998 cwkang1998 force-pushed the test/add-unit-tests-for-components branch from 96a47e7 to c0b6587 Compare January 15, 2025 14:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

LCOV of commit da1b24d during Rust CI #86

	(use "lcov --ignore-errors deprecated,deprecated ..." to suppress this warning)
Reading tracefile /tmp/__zgosalvez_github-actions-report-lcov/lcov.info.
Summary coverage rate:
  source files: 12
  lines.......: 25.4% (366 of 1439 lines)
  functions...: 22.1% (86 of 390 functions)
  branches....: no data found
Message summary:
  1 warning message:
    deprecated: 1

Files changed coverage rate: n/a

@cwkang1998 cwkang1998 force-pushed the test/add-unit-tests-for-components branch from ce8368a to da1b24d Compare January 15, 2025 16:18
@cwkang1998 cwkang1998 requested a review from ametel01 January 15, 2025 16:18
@cwkang1998 cwkang1998 mentioned this pull request Jan 16, 2025
Open
ametel01
ametel01 reviewed Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@ametel01 ametel01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.cargo/config.toml
@@ -26,8 +26,9 @@ rustflags = [
"clippy::match_bool",
"-D",
"clippy::needless_bool",
"-W",
"clippy::unwrap_used",
# Disabling this as unwrap is useful in tests.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use --no-deps flag when you run clippy to skip the tests

@ametel01 ametel01 merged commit 78c9370 into sepolia-db Jan 16, 2025
4 checks passed
@cwkang1998 cwkang1998 deleted the test/add-unit-tests-for-components branch January 27, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ametel01 ametel01 ametel01 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwkang1998 @ametel01