Fixing Sync. #13
Open
Fixing Sync. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #Their state must be populated with the content of our driver. | ||
| #FIXME:Later on, update their state with metadata of our Driver messages. | ||
| for message in self.driver.search(): | ||
| self.theirState.update(message) |
There was a problem hiding this comment.
This would harm perfs. We are making a new full read of the other side (twice since from each side)!
There was a problem hiding this comment.
Nicolas if I will go asymptotic way the reading once will have complexity O(n) and reading it twice O(2n) = O(n). So perfomance won't be affected that much. The previous way of upating stage had bug.
There was a problem hiding this comment.
Trust me. Reading each driver twice will definelty harm perfs.
It's not about algo complexity. It's about I/O.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing sync so that after each sync we get same states. The state must represent the previous other driver.For producing proper changes.