Validator wallet refactor for bold #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljobe
approved these changes
Nov 22, 2024
eljobe
approved these changes
Nov 23, 2024
rauljordan
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR points into bold and should fix using bold with a contract validator wallet, though that hasn't been fully tested yet as there's an issue in the nitro-testnode bold upgrade with the stake token currently.
The main thing this PR does is makes the builder no longer intercept RPC calls. It was always a bit odd that it worked this way, and it didn't play well with bold. Now, the builder uses the signer function to intercept transactions, and overrides the gas limit to prevent gas estimation from failing. The builder also now has support for a "single tx auth", which won't append transactions to the builder (causing concurrency issues with bold) but instead builds a single tx. This means the validator wallet contract doesn't benefit from batching, but if necessary we can figure out a good tx batching strategy for bold in a future PR.
This PR also pulls in OffchainLabs/bold#703 from bold to allow more easily changing the data poster.