Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to disable DAS chunked stores #2796

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add flag to disable DAS chunked stores #2796

wants to merge 5 commits into from

Conversation

ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented Nov 19, 2024 •
edited
Loading

This PR adds a config option- use-legacy-store that forces the das rpc clients to use das_store (legacy) instead of das_startChunkedStore.

Resolves NIT-2949

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Nov 19, 2024
@ganeshvanahalli ganeshvanahalli marked this pull request as ready for review November 19, 2024 13:01
joshuacolvin0
joshuacolvin0 reviewed Nov 19, 2024
View reviewed changes
cmd/datool/datool.go Outdated Show resolved Hide resolved
joshuacolvin0
joshuacolvin0 reviewed Nov 21, 2024
View reviewed changes
das/aggregator.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tristan-Wilson Tristan-Wilson Awaiting requested review from Tristan-Wilson

@gligneul gligneul Awaiting requested review from gligneul

@magicxyyz magicxyyz Awaiting requested review from magicxyyz

@joshuacolvin0 joshuacolvin0 Awaiting requested review from joshuacolvin0

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganeshvanahalli @joshuacolvin0