Fix minor comments from Timeboost PR #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
6 tasks
Co-authored-by: Ganesh Vanahalli <[email protected]>
tsahee
requested changes
Nov 20, 2024
| @@ -231,10 +231,21 @@ func Test_expressLaneService_validateExpressLaneTx(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| type stubPublisher struct { | |||
There was a problem hiding this comment.
not critical:
seems easier to have the stubPublisher hold array of txs and have a publishTransaction function that appends to it. Some tests could use the array, some could use just it's length and some could ignore it completley.
There was a problem hiding this comment.
Refactored it along those lines.
| @@ -31,9 +31,14 @@ type expressLaneControl struct { | |||
| controller common.Address | |||
| } | |||
|
|
|||
| type transactionPublisher interface { | |||
| publishTransactionImpl(context.Context, *types.Transaction, *arbitrum_types.ConditionalOptions, bool) error | |||
There was a problem hiding this comment.
- an interface with private function can get weird if we want to move code around.
- an interface should make sense as itself and func-names should self-document
- I think you only ever pass "true" in that bool, is that right?
Mybe have something like "PublishFastLaneTransaction" or similar that doesn't accept the bool and is trivially implemented in the sequencer or a wrapper?
There was a problem hiding this comment.
Refactored it along those lines.
Base automatically changed from
express-lane-timeboost-input-validation
to
express-lane-timeboost
November 20, 2024 19:23
…res-lane-timeboost-fix-pr-comments
…ments' into expres-lane-timeboost-fix-pr-comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some of the minor issues identified in #2561. This is being submitted as a separate PR for easier review separate from Raul and Terence's work.