Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate data-poster external-signer test certs #2740

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

PlasmaPower
Copy link
Collaborator

The data poster external signer tests were failing because the certificates had expired:

=== RUN   TestExternalSigner/blob_transaction
INFO [10-15|22:26:35.148] http: TLS handshake error from 127.0.0.1:34002: remote error: tls: bad certificate
    dataposter_test.go:108: Error signing transaction with external signer: making signing request to external signer: Post "https://localhost:34719": tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2024-10-15T22:26:35-05:00 is after 2024-10-15T14:40:05Z

This PR adds a shell script to regenerate them, and does so with 100 years until expiry (as these are just test certificates with published private keys, obviously they shouldn't be used for anything except automated unit tests with no funds at risk).

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Oct 16, 2024
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit b452cde into master Oct 16, 2024
17 checks passed
@PlasmaPower PlasmaPower deleted the regenerate-signer-test-certs branch October 16, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants