feat: support google cloud storage as das #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
renlulu
force-pushed
the
feat/das-google-cloud
branch
from
283d2c9
to
67a03db
Compare
Tristan-Wilson
requested changes
Sep 6, 2024
renlulu
force-pushed
the
feat/das-google-cloud
branch
from
5f6ede4
to
2ae64de
Compare
|
Proof of working: |
renlulu
force-pushed
the
feat/das-google-cloud
branch
2 times, most recently
from
a9aee5f
to
0750428
Compare
Tristan-Wilson
requested changes
Sep 10, 2024
renlulu
force-pushed
the
feat/das-google-cloud
branch
from
0750428
to
2209476
Compare
renlulu
force-pushed
the
feat/das-google-cloud
branch
from
8fcdad9
to
67c377d
Compare
Tristan-Wilson
requested changes
Sep 12, 2024
renlulu
force-pushed
the
feat/das-google-cloud
branch
4 times, most recently
from
261a80f
to
98d42fa
Compare
renlulu
force-pushed
the
feat/das-google-cloud
branch
from
98d42fa
to
65b2165
Compare
|
@Tristan-Wilson Hey can we follow up here? |
renlulu
force-pushed
the
feat/das-google-cloud
branch
from
65b2165
to
bee2534
Compare
Tristan-Wilson
requested changes
Sep 27, 2024
Sorry i just saw the comment, I adjust the PR per your request. |
Tristan-Wilson
previously approved these changes
Oct 3, 2024
Tristan-Wilson
approved these changes
Oct 4, 2024
tsahee
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.