Increase the GasLimit to 32000000 #2490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have no real understanding of how this fixes the problem. But, I noticed that it was used a few lines above, and Tsahi also recommended that increasing the limit could fix the tests. This fixes the failing `TestProgramCacheManager` on my local MacOS environment, but does not fix the `TestProgramMemory` which is failing with a slightly different error.
cla-bot
bot
added
the
s
gligneul
previously approved these changes
Jul 16, 2024
This makes it easier to inspect the reason when there are multiple smart contracts interacting.
This change makes it much clearer exactly where the Mac is running out of ink.
This makes is clearer at exactly what point in the code the transaction execution ran out of gas or ink.
Without it, the contract is too big to deploy.
|
Well, this test has begun passing again on my Mac without this change. So, I'm closing this PR and deleting the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny PR that makes
TestProgramCacheManagerpass.However, I don't fully understand why it works. So, I'm nervous and would like someone to explain it to me during review.