Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for after-next-version label to design approved status #2484

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Add check for after-next-version label to design approved status #2484

merged 3 commits into from
Jul 12, 2024

Conversation

PlasmaPower
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 11, 2024
@PlasmaPower PlasmaPower added design-approved after-next-version This PR shouldn't be merged until after the next version is released and removed s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. design-approved after-next-version This PR shouldn't be merged until after the next version is released labels Jul 11, 2024
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 11, 2024
@PlasmaPower PlasmaPower changed the title [Don't merge yet, testing] Add check for after-next-version label to design approved status Add check for after-next-version label to design approved status Jul 11, 2024
joshuacolvin0
joshuacolvin0 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit 9e5f946 into master Jul 12, 2024
14 checks passed
@joshuacolvin0 joshuacolvin0 deleted the after-next-version-check branch July 12, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

Assignees
No one assigned
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PlasmaPower @joshuacolvin0