Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't save every state on archive node #1542

Merged
merged 28 commits into from
Sep 27, 2023
Merged

Don't save every state on archive node #1542

merged 28 commits into from
Sep 27, 2023

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented Mar 29, 2023 •
edited
Loading

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Mar 29, 2023
@magicxyyz magicxyyz changed the base branch from master to recreate-state-for-rpcs March 29, 2023 17:47
@magicxyyz magicxyyz marked this pull request as ready for review April 11, 2023 18:07
@PlasmaPower PlasmaPower requested a review from tsahee June 9, 2023 06:42
tsahee
tsahee reviewed Jun 16, 2023
View reviewed changes
system_tests/common_test.go Outdated Show resolved Hide resolved
system_tests/recreatestate_rpc_test.go Outdated Show resolved Hide resolved
system_tests/recreatestate_rpc_test.go Outdated Show resolved Hide resolved
system_tests/recreatestate_rpc_test.go Outdated Show resolved Hide resolved
system_tests/recreatestate_rpc_test.go Outdated Show resolved Hide resolved
system_tests/recreatestate_rpc_test.go Outdated Show resolved Hide resolved
system_tests/recreatestate_rpc_test.go Outdated Show resolved Hide resolved
system_tests/recreatestate_rpc_test.go Outdated Show resolved Hide resolved
system_tests/recreatestate_rpc_test.go Outdated Show resolved Hide resolved
system_tests/recreatestate_rpc_test.go Outdated Show resolved Hide resolved
Base automatically changed from recreate-state-for-rpcs to master August 15, 2023 18:38
@Enigmatic331
Copy link

👀 just checking in... 🙏 is this currently still work in progress?

joshuacolvin0
joshuacolvin0 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit 5534bc6 into master Sep 27, 2023
7 checks passed
@joshuacolvin0 joshuacolvin0 deleted the dont-save-every-state branch September 27, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsahee tsahee tsahee left review comments

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@magicxyyz @Enigmatic331 @joshuacolvin0 @tsahee