Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge geth 1.13.3 #284

Merged
merged 110 commits into from
Jan 26, 2024
Merged

Merge geth 1.13.3 #284

merged 110 commits into from
Jan 26, 2024

Commits on Sep 12, 2023

  1. Configuration menu
    Copy the full SHA
    766272f View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Configuration menu
    Copy the full SHA
    43df612 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8d38b1f View commit details
    Browse the repository at this point in the history
  3. metrics: refactor metrics (#28035)

    This change includes a lot of things, listed below. 
    
    ### Split up interfaces, write vs read
    
    The interfaces have been split up into one write-interface and one read-interface, with `Snapshot` being the gateway from write to read. This simplifies the semantics _a lot_. 
    
    Example of splitting up an interface into one readonly 'snapshot' part, and one updatable writeonly part: 
    
    ```golang
    type MeterSnapshot interface {
    	Count() int64
    	Rate1() float64
    	Rate5() float64
    	Rate15() float64
    	RateMean() float64
    }
    
    // Meters count events to produce exponentially-weighted moving average rates
    // at one-, five-, and fifteen-minutes and a mean rate.
    type Meter interface {
    	Mark(int64)
    	Snapshot() MeterSnapshot
    	Stop()
    }
    ```
    
    ### A note about concurrency
    
    This PR makes the concurrency model clearer. We have actual meters and snapshot of meters. The `meter` is the thing which can be accessed from the registry, and updates can be made to it. 
    
    - For all `meters`, (`Gauge`, `Timer` etc), it is assumed that they are accessed by different threads, making updates. Therefore, all `meters` update-methods (`Inc`, `Add`, `Update`, `Clear` etc) need to be concurrency-safe. 
    - All `meters` have a `Snapshot()` method. This method is _usually_ called from one thread, a backend-exporter. But it's fully possible to have several exporters simultaneously: therefore this method should also be concurrency-safe. 
    
    TLDR: `meter`s are accessible via registry, all their methods must be concurrency-safe. 
    
    For all `Snapshot`s, it is assumed that an individual exporter-thread has obtained a `meter` from the registry, and called the `Snapshot` method to obtain a readonly snapshot. This snapshot is _not_ guaranteed to be concurrency-safe. There's no need for a snapshot to be concurrency-safe, since exporters should not share snapshots. 
    
    Note, though: that by happenstance a lot of the snapshots _are_ concurrency-safe, being unmutable minimal representations of a value. Only the more complex ones are _not_ threadsafe, those that lazily calculate things like `Variance()`, `Mean()`.
    
    Example of how a background exporter typically works, obtaining the snapshot and sequentially accessing the non-threadsafe methods in it: 
    ```golang
    		ms := metric.Snapshot()
                    ...
    		fields := map[string]interface{}{
    			"count":    ms.Count(),
    			"max":      ms.Max(),
    			"mean":     ms.Mean(),
    			"min":      ms.Min(),
    			"stddev":   ms.StdDev(),
    			"variance": ms.Variance(),
    ```
    
    TLDR: `snapshots` are not guaranteed to be concurrency-safe (but often are).
    
    ### Sample changes
    
    I also changed the `Sample` type: previously, it iterated the samples fully every time `Mean()`,`Sum()`, `Min()` or `Max()` was invoked. Since we now have readonly base data, we can just iterate it once, in the constructor, and set all four values at once. 
    
    The same thing has been done for runtimehistogram. 
    
    ### ResettingTimer API
    
    Back when ResettingTImer was implemented, as part of ethereum/go-ethereum#15910, Anton implemented a `Percentiles` on the new type. However, the method did not conform to the other existing types which also had a `Percentiles`. 
    
    1. The existing ones, on input, took `0.5` to mean `50%`. Anton used `50` to mean `50%`. 
    2. The existing ones returned `float64` outputs, thus interpolating between values. A value-set of `0, 10`, at `50%` would return `5`, whereas Anton's would return either `0` or `10`. 
    
    This PR removes the 'new' version, and uses only the 'legacy' percentiles, also for the ResettingTimer type. 
    
    The resetting timer snapshot was also defined so that it would expose the internal values. This has been removed, and getters for `Max, Min, Mean` have been added instead. 
    
    ### Unexport types
    
    A lot of types were exported, but do not need to be. This PR unexports quite a lot of them.
    holiman authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    8b6cf12 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    eb74389 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. eth: abort on api operations not available in pbss-mode (#28104)

    eth: abort on api calls not supporting pbss
    s1na authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    b9b99a1 View commit details
    Browse the repository at this point in the history
  2. cmd/geth, internal/flags, go.mod: colorize cli help, support env vars…

    … (#28103)
    
    * cmd/geth, internal/flags, go.mod: colorize cli help, support env vars
    
    * internal/flags: use stdout, not stderr for terminal detection
    karalabe authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    d9fbb71 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    636c64c View commit details
    Browse the repository at this point in the history
  4. internal/flags: fix linter

    karalabe committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    86bc2cd View commit details
    Browse the repository at this point in the history
  5. graphql: add 4844 blob fields (#27963)

    This adds block and receipt fields for EIP-4844.
    
    ---------
    
    Signed-off-by: jsvisa <[email protected]>
    Co-authored-by: Sina Mahmoodi <[email protected]>
    jsvisa and s1na authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    8514d66 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ee65462 View commit details
    Browse the repository at this point in the history
  7. rlp/rlpgen: remove build tag (#28106)

    * rlp/rlpgen: remove build tag
    
    This tag was supposed to prevent unstable output when types reference each other. Imagine
    there are two struct types A and B, where a reference to type B is in A. If I run rlpgen
    on type B first, and then on type A, the generator will see the B.EncodeRLP method and
    call it. However, if I run rlpgen on type A first, it will inline the encoding of B.
    
    The solution I chose for the initial release of rlpgen was to just ignore methods
    generated by rlpgen using a build tag. But there is a problem with this: if any code in
    the package calls EncodeRLP explicitly, the package can't be loaded without errors anymore
    in rlpgen, because the loader ignores it. Would be nice if there was a way to just make it
    ignore invalid functions during type checking (they're not necessary for rlpgen), but
    golang.org/x/tools/go/packages does not provide a way of ignoring them.
    
    Luckily, the types we use rlpgen with do not reference each other right now, so we can
    just remove the build tags for now.
    fjl authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    909dd4a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    65a17c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. core/state: check err for iter.Error in fastDeleteStorage (#28122)

    core/state: check err for iter.Error
    darioush authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    48fdb79 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4fa3db4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    16cd1a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. Configuration menu
    Copy the full SHA
    9a9db3d View commit details
    Browse the repository at this point in the history
  2. internal/ethapi: correctly calculate effective gas price (#28130)

    correctly calculate effective gas price
    cam-schultz authored Sep 17, 2023
    Configuration menu
    Copy the full SHA
    2177193 View commit details
    Browse the repository at this point in the history
  3. internal/flags: fix typo (#28133)

    fix(flag): one typo
    phenix3443 authored Sep 17, 2023
    Configuration menu
    Copy the full SHA
    52234eb View commit details
    Browse the repository at this point in the history
  4. params: fix typo in comment (#28129)

    fix: typo
    phenix3443 authored Sep 17, 2023
    Configuration menu
    Copy the full SHA
    d8a351b View commit details
    Browse the repository at this point in the history
  5. core, eth/downloader: fix genesis state missing due to state sync (#2…

    …8124)
    
    * core: fix chain repair corner case in path-based scheme
    
    * eth/downloader: disable trie database whenever state sync is launched
    rjl493456442 authored Sep 17, 2023
    Configuration menu
    Copy the full SHA
    c53b0fe View commit details
    Browse the repository at this point in the history
  6. params: release Geth v1.13.1

    karalabe committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    3f40e65 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    90d5bd8 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. cmd/evm: fix some issues with the evm run command (#28109)

    * cmd/evm: improve flags handling
    
    This fixes some issues with flags in cmd/evm. The supported flags did not
    actually show up in help output because they weren't categorized. I'm also
    adding the VM-related flags to the run command here so they can be given
    after the subcommand name. So it can be run like this now:
    
       ./evm run --code 6001 --debug
    
    * cmd/evm: enable all forks by default in run command
    
    The default genesis was just empty with no forks at all, which is annoying because
    contracts will be relying on opcodes introduced in a fork. So this changes the default to
    have all forks enabled.
    
    * core/asm: fix some issues in the assembler
    
    This fixes minor bugs in the old assembler:
    
    - It is now possible to have comments on the same line as an instruction.
    - Errors for invalid numbers in the jump instruction are reported better
    - Line numbers in errors were off by one
    fjl authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e9f78db View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef76afa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4b748b7 View commit details
    Browse the repository at this point in the history
  4. cmd/devp2p: use bootnodes as crawl input (#28139)

    This PR makes the tool use the --bootnodes list as the input to devp2p crawl.
    The flag will take effect if the input/output.json file is missing or empty.
    jsvisa authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    41a0ad9 View commit details
    Browse the repository at this point in the history
  5. go.mod: use existing version of karalabe/usb (#28127)

    There is no 0.0.3 release of karalabe/usb.
    holiman authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    30d5d7c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7ed5bc0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5c6f4b9 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. cmd/clef: suppress fsnotify error if keydir not exists (#28160)

    As the keydir will be automatically created after an account is created, no error message if the watcher is failed.
    jsvisa authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    5b9cbe3 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. core/rawdb: no need to run truncateFile for readonly mode (#28145)

    Avoid truncating files, if ancients are opened in readonly mode. With this change, we return error instead of trying (and failing)  to repair
    jsvisa authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    545f4c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. trie: remove internal nodes between shortNode and child in path mode …

    …(#28163)
    
    * trie: remove internal nodes between shortNode and child in path mode
    
    * trie: address comments
    
    * core/rawdb, trie: address comments
    
    * core/rawdb: delete unused func
    
    * trie: change comments
    
    * trie: add missing tests
    
    * trie: fix lint
    rjl493456442 authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    4773dcb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    03c2176 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    83f3fc2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d135baf View commit details
    Browse the repository at this point in the history
  5. core/rawdb: use readonly file lock in readonly mode (#28180)

    This allows using the freezer from multiple processes at once
    in read-only mode.
    
    Co-authored-by: Martin Holst Swende <[email protected]>
    jsvisa and holiman authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    f1b2ec0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    82ec555 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Configuration menu
    Copy the full SHA
    323542a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d051ea5 View commit details
    Browse the repository at this point in the history
  3. core/bloombits: fix deadlock when matcher session hits an error (#28184)

    When MatcherSession encounters an error, it attempts to close the session.
    Closing waits for all goroutines to finish, including the 'distributor'. However, the
    distributor will not exit until all requests have returned.
    
    This patch fixes the issue by delivering the (empty) result to the distributor
    before calling Close().
    msmania authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c2cfe35 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1fa3362 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c3742a9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3d297fc View commit details
    Browse the repository at this point in the history
  7. cmd/utils: fix bootnodes config priority (#28095)

    This fixes an issue where the --bootnodes flag was overridden by the config file.
    
    ---------
    
    Co-authored-by: NathanBSC <[email protected]>
    Co-authored-by: Felix Lange <[email protected]>
    3 people authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    f6f64cc View commit details
    Browse the repository at this point in the history
  8. ethclient: fix BlockReceipts parameter encoding (#28087)

    Co-authored-by: Felix Lange <[email protected]>
    kandrianov and fjl authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    4985d83 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. core/vm: minor code formatting (#28199)

    Adding a space beween function opOrigin() and opcCaller() in instruciton.go.
    Adding a space beween function opkeccak256()  and opAddress() in instruciton.go.
    hzysvilla authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    4de89e9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4021910 View commit details
    Browse the repository at this point in the history
  3. eth/fetcher: allow underpriced transactions in after timeout (#28097)

    This PR will allow a previously underpriced transaction back in after a timeout
    of 5 minutes. This will block most transaction spam but allow for transactions to
    be re-broadcasted on networks with less transaction flow.
    
    ---------
    
    Co-authored-by: Felix Lange <[email protected]>
    MariusVanDerWijden and fjl authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    2b7bc2c View commit details
    Browse the repository at this point in the history
  4. internal/ethapi: eth_call block parameter is optional (#28165)

    So apparently in the spec the base block parameter of eth_call is optional.
    I agree that "latest" is a sane default for this that most people would use.
    s1na authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    adb9b31 View commit details
    Browse the repository at this point in the history
  5. eth/downloader: remove header rollback mechanism (#28147)

    * eth/downloader: remove rollback mechanism in downloader
    
    * eth/downloader: remove the tests
    rjl493456442 authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b85c183 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. core/txpool: fix typos (#28208)

    core/txpool:fix typos
    bnovil authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    614804b View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. core/txpool: fix typos (#28213)

    fix(core/txpool): fix typos
    0xbstn authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a081130 View commit details
    Browse the repository at this point in the history
  2. core, accounts, eth, trie: handle genesis state missing (#28171)

    * core, accounts, eth, trie: handle genesis state missing
    
    * core, eth, trie: polish
    
    * core: manage txpool subscription in mainpool
    
    * eth/backend: fix test
    
    * cmd, eth: fix test
    
    * core/rawdb, trie/triedb/pathdb: address comments
    
    * eth, trie: address comments
    
    * eth: inline the function
    
    * eth: use synced flag
    
    * core/txpool: revert changes in txpool
    
    * core, eth, trie: rename functions
    rjl493456442 authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    73f5bcb View commit details
    Browse the repository at this point in the history
  3. params: release Geth v1.13.2

    karalabe committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    dc34fe8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3dc45a3 View commit details
    Browse the repository at this point in the history
  5. params: update 4788 beacon roots contract addr (#28205)

    This change contains the final (?) address for 4788 beacon root contract. The update to the EIP is being tracked here: ethereum/EIPs#7672
    
    ---------
    
    Co-authored-by: Martin Holst Swende <[email protected]>
    lightclient and holiman authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    37a2d91 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    46c850a View commit details
    Browse the repository at this point in the history
  7. core, eth: typos and some code formatting (#28201)

    * fix: typo
    
    * feat: revert symbol name
    phenix3443 authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    b9450bf View commit details
    Browse the repository at this point in the history
  8. ethdb, internal/ethapi: support exposing Pebble stats too, beside Lev…

    …elDB (#28224)
    
    ethdb, internal/ethapi: support exposing Pebble stats too, besinde LevelDB
    karalabe authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    f988b23 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. core: fix typos (#28218)

    * fix(core/txpool): fix typos
    
    * core/asm: fix typos
    
    * core/bloombits: fix typos
    
    * core/rawdb: fix typos
    0xbstn authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    1f6e639 View commit details
    Browse the repository at this point in the history
  2. core: infer blobGasUsed in chain maker (#28212)

    Same way that the gasUsed in header is updated when a tx 
    is added we should update blob gas used instead of requiring caller
    to set it manually.
    s1na authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    0ded110 View commit details
    Browse the repository at this point in the history
  3. core/state: small trie prefetcher nits (#28183)

    Small trie prefetcher nits
    aaronbuchwald authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    c5ff839 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1f9d672 View commit details
    Browse the repository at this point in the history
  5. ethdb/pebble: upgrade pebble to master (aa077af62593) (#28070)

    * ethdb/pebble: upgrade pebble
    
    * ethdb/pebble, go.mod: update pebble to master (aa077af62593)
    
    ---------
    
    Co-authored-by: Péter Szilágyi <[email protected]>
    rjl493456442 and karalabe authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    22dcb7a View commit details
    Browse the repository at this point in the history
  6. ethdb/pebble: luv you linter

    karalabe committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    966e50b View commit details
    Browse the repository at this point in the history
  7. eth/catalyst: add validation error in new paylaod hash mismatch (#28226)

    * eth/catalyst: add validation error in new paylaod hash mismatch
    
    * eth/catalyst/api: refactor api.invalid(..) to return nil latest valid hash if none provided
    lightclient authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    a408e37 View commit details
    Browse the repository at this point in the history
  8. cmd, eth: switch the dev synctarget to hash from block (#28209)

    * cmd, eth: switch the dev synctarget to hash from block
    
    * cmd/utils, eth/catalyst: terminate node wyen synctarget reached
    karalabe authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    7b6ff52 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. core: implement BLOBBASEFEE opcode (0x4a) (#28098)

    Implements "EIP-7516: BLOBBASEFEE opcode" for cancun, as per spec: https://eips.ethereum.org/EIPS/eip-7516
    MariusVanDerWijden authored Oct 2, 2023
    Configuration menu
    Copy the full SHA
    c39cbc1 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. eth, rpc: add configurable option for wsMessageSizeLimit (#27801)

    This change adds a configurable limit to websocket message. 
    ---------
    
    Co-authored-by: Martin Holst Swende <[email protected]>
    tylerni7 and holiman authored Oct 3, 2023
    Configuration menu
    Copy the full SHA
    705a51e View commit details
    Browse the repository at this point in the history
  2. cmd/evm: cancun-updates for b11r and t8n -tools (#28195)

    This change updates `evm b11r` (blockbuilder) and `evm t8n` (transition) tools to contain cancun updates (e.g. new header fields)
    ---------
    
    Co-authored-by: Mario Vega <[email protected]>
    lightclient and marioevz authored Oct 3, 2023
    Configuration menu
    Copy the full SHA
    07dec7a View commit details
    Browse the repository at this point in the history
  3. core: fix typos (#28238)

    0xbstn authored Oct 3, 2023
    Configuration menu
    Copy the full SHA
    339a4cf View commit details
    Browse the repository at this point in the history
  4. trie: fix benchmark by ensuring key immutability (#28221)

    This change fixes the bug in a benchmark, where the input to the trie is reused in a way which is not correct. 
    
    ---------
    
    Co-authored-by: Martin Holst Swende <[email protected]>
    DeVil2O and holiman authored Oct 3, 2023
    Configuration menu
    Copy the full SHA
    2091ebd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7963c4e View commit details
    Browse the repository at this point in the history
  6. cmd/devp2p, eth: drop eth/66 (#28239)

    * cmd/devp2p, eth: drop eth/66
    
    * eth/protocols/eth: yes sir, linter
    karalabe authored Oct 3, 2023
    Configuration menu
    Copy the full SHA
    bc6d184 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. core, eth, miner: start propagating and consuming blob txs (#28243)

    * core, eth, miner: start propagating and consuming blob txs
    
    * eth/protocols/eth: disable eth/67 if Cancun is enabled
    
    * core/txpool, eth, miner: pass gas limit infos in lazy tx for mienr filtering
    
    * core/txpool, miner: add lazy resolver for pending txs too
    
    * core, eth: fix review noticed bugs
    
    * eth, miner: minor polishes in the mining and announcing logs
    
    * core/expool: unsubscribe the event scope
    karalabe authored Oct 4, 2023
    Configuration menu
    Copy the full SHA
    a8a9c8e View commit details
    Browse the repository at this point in the history
  2. eth: when snap is complaining for missing eth, be verbose about the d…

    …etails (#28249)
    
    * eth: when snap is complaining for missing eth, be verbost about the details
    
    * eth: lower snapshot registration error verbosity
    karalabe authored Oct 4, 2023
    Configuration menu
    Copy the full SHA
    95b0555 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    052355f View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2023

  1. Configuration menu
    Copy the full SHA
    4e1e373 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. trie: refactor stacktrie (#28233)

    This change refactors stacktrie to separate the stacktrie itself from the
    internal representation of nodes: a stacktrie is not a recursive structure
    of stacktries, rather, a framework for representing and operating upon a set of nodes.
    
    ---------
    
    Co-authored-by: Gary Rong <[email protected]>
    holiman and rjl493456442 authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    0832679 View commit details
    Browse the repository at this point in the history
  2. core: fix typos (#28255)

    fixes various typos in core
    0xbstn authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    fa6107c View commit details
    Browse the repository at this point in the history
  3. eth, params: fix typos (#28286)

    * eth/ethconfig: fix typo on comment
    
    * params/config: fix typo on comment
    
    * eth/ethconfig: fix typo on comment
    hyunchel authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    db9afae View commit details
    Browse the repository at this point in the history
  4. all: move light.NodeSet to trienode.ProofSet (#28287)

    This is a minor refactor in preparation of changes to range verifier. This PR contains no intentional functional changes but moves (and renames) the light.NodeSet
    holiman authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    6b1e4f4 View commit details
    Browse the repository at this point in the history
  5. trie: fix a typo, use correct docstrings (#28302)

    * fix a typo
    
    * trie: additional fixes to docstrings
    
    ---------
    
    Co-authored-by: Martin Holst Swende <[email protected]>
    bnovil and holiman authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    6505297 View commit details
    Browse the repository at this point in the history
  6. eth: enforce announcement metadatas and drop peers violating the prot…

    …ocol (#28261)
    
    * eth: enforce announcement metadatas and drop peers violating the protocol
    
    * eth/fetcher: relax eth/68 validation a bit for flakey clients
    
    * tests/fuzzers/txfetcher: pull in suggestion from Marius
    
    * eth/fetcher: add tests for peer dropping
    
    * eth/fetcher: linter linter linter linter linter
    karalabe authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    8afbcf4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5e43ed0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2c007cf View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. trie: remove owner and binary marshaling from stacktrie (#28291)

    This change
      - Removes the owner-notion from a stacktrie; the owner is only ever needed for comitting to the database, but the commit-function, the `writeFn` is provided by the caller, so the caller can just set the owner into the `writeFn` instead of having it passed through the stacktrie.
      - Removes the `encoding.BinaryMarshaler`/`encoding.BinaryUnmarshaler` interface from stacktrie. We're not using it, and it is doubtful whether anyone downstream is either.
    holiman authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    8976a0c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7776a32 View commit details
    Browse the repository at this point in the history
  3. eth/fetcher: throttle tx fetches to 128KB responses (#28304)

    * eth/fetcher: throttle tx fetches to 128KB responses
    
    * eth/fetcher: unindent a clause per review request
    karalabe authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    a6deb2d View commit details
    Browse the repository at this point in the history
  4. eth/fetcher: fix typo

    karalabe committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    13d1d42 View commit details
    Browse the repository at this point in the history
  5. cmd, core: resolve scheme from a read-write database (#28313)

    * cmd, core: resolve scheme from a read-write database
    
    * cmd, core, eth: move the scheme check in the ethereum constructor
    
    * cmd/geth: dump should in ro mode
    
    * cmd: reverts
    rjl493456442 authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    eeb5dc3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0004c6b View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Configuration menu
    Copy the full SHA
    d2c0bed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0d45d72 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Configuration menu
    Copy the full SHA
    ff3bbcc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6a1f508 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Merge upstream commit #28135

    eth/catalyst: fix engine API (#28135)
    
     Conflicts:
      eth/catalyst/api.go
    Conflicts due to us adding arbosversion to checkAttribute. Accepted
    both.
    
     Test fails:
    metrics/influxdb tests fail here, but they also fail on the merged
    upstream commit
    tsahee committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    9f6dbf5 View commit details
    Browse the repository at this point in the history
  2. Merge upstream commit #28124

    eth/downloader: fix genesis state missing due to state sync (#28124)
    
     Conflicts:
      core/blockchain.go
    These conflicts were dut to our changes in setHeadBeyondRoot.
    In the function call upstream only indented the code, but tested
    Upstream also added to the file an assumption that genesis is block 0,
    which we removed.
    tsahee committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    addac58 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    022ddb9 View commit details
    Browse the repository at this point in the history
  4. Merge upstream PR 28180

    core/rawdb: use readonly file lock in readonly mode (#28180)
    
     Conflicts:
      core/rawdb/freezer.go
    Conflict around our change from flock to NewFileLock.
    Accepted both.
    
     Additions:
      core/rawdb/fileutil{,_mock}.db:
    Added the now-used RLock to out interface, with a mock implementation
    for wasm.
    tsahee committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    6460f6e View commit details
    Browse the repository at this point in the history
  5. Merge upstream PR 28165

    internal/ethapi: eth_call block parameter is optional (#28165)
    
     Conflicts:
    	internal/ethapi/api.go
    api: conflict because we added a param to DoCall, accept both changes.
    tsahee committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    02ecac8 View commit details
    Browse the repository at this point in the history
  6. Merge upstream PR #28171

    core, accounts, eth, trie: handle genesis state missing (#28171)
    
     Conflicts:
      core/blockchain.go
    We made many changes in setHeadBeyondRoot. upstream removed assumption
    that genesis state is always in the db. Accepted both changes
    tsahee committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    ed35443 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    208af57 View commit details
    Browse the repository at this point in the history
  8. Merge upstream PR 28098

    implement BLOBBASEFEE opcode (0x4a) (#28098)
    
     Conflicts:
      core/evm.go
      core/vm/evm.go
    Both nitro and upstream added fields to BlockContextx. Using both.
    
     Additions:
      accounts/abi/bind/base.go
      eth/tracers/js/goja.go
    common.Address no longer has the Hash() function that we sometimes used.
    It now, however, has a Big() function.
    Previous calls to Address.Hash().Big() were converted to .Big()
    tsahee committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    efaca34 View commit details
    Browse the repository at this point in the history
  9. Merge upstream PR 28238

    core: fix typos (#28238)
    
     Conflicts:
      core/types/transaction.go
    Upstream fixed a comment, we had a change in the next code-line,
    accept both changes.
    tsahee committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    3ece0e0 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1c7cc5a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    85f420d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e5ecb9d View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Configuration menu
    Copy the full SHA
    18a471f View commit details
    Browse the repository at this point in the history