Upgrade ConditionalOptions variables to type math.HexOrDecimal64 to support eth_sendRawTransactionConditional #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wTransactionConditional
ganeshvanahalli
changed the title
PlasmaPower
approved these changes
Sep 1, 2023
| {input: `"0x2F2"`, want: uint64(0x2f2)}, | ||
| {input: `"0x1122aaff"`, want: uint64(0x1122aaff)}, | ||
| {input: `"0xbbb"`, want: uint64(0xbbb)}, | ||
| {input: `"0xffffffffffffffff"`, want: uint64(0xffffffffffffffff)}, |
There was a problem hiding this comment.
I think the hex based inputs should be "\"0x2\"" for example, as the strings are supposed to be JSON, but this doesn't matter with the current implementation of HexOrDecimal64. A follow-up PR to fix this might still be good :)
There was a problem hiding this comment.
That, or we could call UnmarshalText instead of UnmarshalJSON in the test
There was a problem hiding this comment.
Agreed, the previous tests covered UnmarshalText so I wanted to test for JSON too, I'll put a followup PR to fix the inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.