chore: renames L1ToL2Message to parentChain/Chain #344
Conversation
| @@ -70,8 +70,8 @@ export const getCustomNetworks = async ( | |||
| l1Url: string, | |||
| l2Url: string | |||
| ): Promise<{ | |||
| l1Network: L1Network | |||
| l2Network: Omit<L2Network, 'tokenBridge'> | |||
| l1Network: ParentChain | |||
There was a problem hiding this comment.
should we rename the vars too - parentChain and childChain?
There was a problem hiding this comment.
We should. I think we should do that in a separate PR because that will change ~200 uses in the test files.
| l1Network: L1Network | ||
| l2Network: Omit<L2Network, 'tokenBridge'> | ||
| l1Network: ParentChain | ||
| l2Network: Omit<ChildChain, 'tokenBridge'> | ||
| }> => { | ||
| const l1Provider = new JsonRpcProvider(l1Url) |
There was a problem hiding this comment.
Should we rename these inner vars too - eg childProvider, childNetworkInfo etc. I guess the general pattern is just get rid of l1/l2 everywhere. So my comments are the same for this throughout.
There was a problem hiding this comment.
I'll change those in a future PR because they're exported out of this function and used in the tests.
| @@ -22,8 +22,8 @@ import { L2ContractTransaction } from '../message/L2Transaction' | |||
|
|
|||
| import { | |||
| parentChains as l1Networks, | |||
| ParentChain as L1Network, | |||
| ChildChain as L2Network, | |||
There was a problem hiding this comment.
Are these renamings happening in another PR?
There was a problem hiding this comment.
Yes sir. All the import as assertions created in these PRs.
closes #341