Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flyway #1569

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Update flyway #1569

merged 3 commits into from
Oct 28, 2024

Conversation

twerthi
Copy link
Contributor

@twerthi twerthi commented Oct 28, 2024


Background

Redgate has changed their method for their licensing from a license key to a personal access token. This PR adds the new PAT method and provides a warning that the license key method has been deprecated and will be removed in future versions.

Results

Enterprise features successfully work using the PAT method.

Before

The only way to use Enterprise features was to use the license key, which has been deprecated by Redgate.

After

Enterprise features will now work using either the PAT or license key methods, a warning is displayed if the license key is used letting the user know that it will be removed in future versions.

Pre-requisites

  • Id should be a GUID that is not 00000000-0000-0000-0000-000000000000
    • NOTE If you are modifying an existing step template, please make sure that you do not modify the Id property (updating the Id will break the Library sync functionality in Octopus).
  • Version should be incremented, otherwise the integration with Octopus won't update the step template correctly
  • Parameter names should not start with $
  • Step template parameter names (the ones declared in the JSON, not the script body) should be prefixed with a namespace so that they are less likely to clash with other user-defined variables in Octopus (see this issue). For example, use an abbreviated name of the step template or the category of the step template).
  • LastModifiedBy field must be present, and (optionally) updated with the correct author
  • The best practices documented here have been applied
  • If a new Category has been created:
    • An image with the name {categoryname}.png must be present under the step-templates/logos folder
    • The switch in the humanize function in gulpfile.babel.js must have a case statement corresponding to it

Fixes # . If there is an open issue that this PR fixes add it here, otherwise just remove this line

Copy link

Start Hyponome locally

docker pull ghcr.io/hnrkndrssn/hyponome:main
docker run --rm -p 8000:8080 -it ghcr.io/hnrkndrssn/hyponome:main

Review in Hyponome

@@ -10536,6 +10536,7 @@
"moment": "^2.13.0",
"node-uuid": "^1.4.7",
"normalize.css": "^4.1.1",
"octopus-library": "file:",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twerthi - is this expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question, I'm not sure. I hadn't noticed it was included, I didn't run anything that would have produced it, just updated the JSON file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mindful of changes to the package-lock file generally. If you arent expecting it to change, I'd probably say revert it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled file from main branch and overwrote PR branch.

Copy link
Contributor

@harrisonmeister harrisonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself looks good. Just the query over the package-lock.json file

Copy link
Contributor

@harrisonmeister harrisonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harrisonmeister harrisonmeister merged commit 2e92a2e into master Oct 28, 2024
2 checks passed
@harrisonmeister harrisonmeister deleted the update-flyway branch October 28, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants