-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flyway #1569
Update flyway #1569
Conversation
Start Hyponome locally
|
package-lock.json
Outdated
@@ -10536,6 +10536,7 @@ | |||
"moment": "^2.13.0", | |||
"node-uuid": "^1.4.7", | |||
"normalize.css": "^4.1.1", | |||
"octopus-library": "file:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@twerthi - is this expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question, I'm not sure. I hadn't noticed it was included, I didn't run anything that would have produced it, just updated the JSON file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm mindful of changes to the package-lock file generally. If you arent expecting it to change, I'd probably say revert it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled file from main branch and overwrote PR branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change itself looks good. Just the query over the package-lock.json file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Background
Redgate has changed their method for their licensing from a
license key
to apersonal access token
. This PR adds the new PAT method and provides a warning that the license key method has been deprecated and will be removed in future versions.Results
Enterprise features successfully work using the PAT method.
Before
The only way to use Enterprise features was to use the license key, which has been deprecated by Redgate.
After
Enterprise features will now work using either the PAT or license key methods, a warning is displayed if the license key is used letting the user know that it will be removed in future versions.
Pre-requisites
Id
should be a GUID that is not00000000-0000-0000-0000-000000000000
Id
property (updating theId
will break the Library sync functionality in Octopus).Version
should be incremented, otherwise the integration with Octopus won't update the step template correctly$
LastModifiedBy
field must be present, and (optionally) updated with the correct authorCategory
has been created:{categoryname}.png
must be present under thestep-templates/logos
folderswitch
in thehumanize
function ingulpfile.babel.js
must have acase
statement corresponding to itFixes # . If there is an open issue that this PR fixes add it here, otherwise just remove this line