Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Vertical velocity calculation and diagnostic plot #59

Merged
merged 15 commits into from
Nov 1, 2024

Conversation

eleanorfrajka
Copy link
Collaborator

Added functions to calculate vertical velocities:

  • calc_seawater_w which differences the glider modelled velocity (VERT_GLIDER_SPEED) and the glider computed speed (VERT_SPEED_DZDT)
  • calc_glider_w_from_depth which calculates vertical speed from the centred first difference on DEPTH and TIME.

Added function to plot the velocities so that you can visually check (for a small range of profiles) whether the differencing is going the right way around, and a histogram to see where the computed seawater w ends up.

…to calculate glider vertical speed from dzdt. Created a diagnostic plot (plot_vertical_speeds_with_histograms)
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

glidertest/tools.py Outdated Show resolved Hide resolved
Copy link
Member

@callumrollo callumrollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additional functionality!. Once the attributes are added to vert speed variables I think is good to merge

glidertest/tools.py Outdated Show resolved Hide resolved
glidertest/tools.py Outdated Show resolved Hide resolved
@callumrollo
Copy link
Member

It's not finding a variable DEPTH_Z does this need an updated version of the seaglider data file?

@callumrollo callumrollo merged commit 75fd0da into main Nov 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants