Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] add Eleanor's dataset and clean out old datasets from fetcher #57

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

callumrollo
Copy link
Member

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@callumrollo
Copy link
Member Author

The tests should run faster now that it's not downloading all the old datasets

@eleanorfrajka
Copy link
Collaborator

Ok - checked with ReviewNB and then the file differences for the *.py. I guess I'm mostly checking that there haven't been inadvertent deletions and that the changes look sensible? since the tests also ran..

Copy link
Collaborator

@eleanorfrajka eleanorfrajka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, now I found the review changes button.

@callumrollo callumrollo merged commit 11c10d5 into main Nov 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants