-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for tests #19
Prepare for tests #19
Conversation
Ok I feel like I made a but of a mess before and now I cant undo it @callumrollo |
Looks fine! Now you just need to add some tests. Try to get them to run locally before committing, then we can work on stuff like github actions to run them automatically |
@callumrollo ok I should have added all. I used the same functions you suggested, worked fine when I tested it locally |
Should we do the workflow separately? |
nah add that in too, get it all done in one :) |
@callumrollo windows and mac tests are super slow, do we want to keep them anyways? |
It's good to test against a wide range of systems. We should ideally get to the bottom of this. I'll see if they also are slow on #16 otherwise we can remove the windows and mac tests for now |
Sounds good! Let's see how it runs on the other one |
Why is mine so slow? |
Wohooooo! |
No description provided.