Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for tests #19

Merged
merged 9 commits into from
Jul 1, 2024

Conversation

MOchiara
Copy link
Member

@MOchiara MOchiara commented Jul 1, 2024

No description provided.

@MOchiara
Copy link
Member Author

MOchiara commented Jul 1, 2024

Ok I feel like I made a but of a mess before and now I cant undo it @callumrollo

@callumrollo
Copy link
Member

Looks fine! Now you just need to add some tests. Try to get them to run locally before committing, then we can work on stuff like github actions to run them automatically

@MOchiara
Copy link
Member Author

MOchiara commented Jul 1, 2024

@callumrollo ok I should have added all. I used the same functions you suggested, worked fine when I tested it locally

@MOchiara
Copy link
Member Author

MOchiara commented Jul 1, 2024

Should we do the workflow separately?

@callumrollo
Copy link
Member

nah add that in too, get it all done in one :)

@MOchiara
Copy link
Member Author

MOchiara commented Jul 1, 2024

@callumrollo windows and mac tests are super slow, do we want to keep them anyways?

@callumrollo
Copy link
Member

It's good to test against a wide range of systems. We should ideally get to the bottom of this. I'll see if they also are slow on #16 otherwise we can remove the windows and mac tests for now

@MOchiara
Copy link
Member Author

MOchiara commented Jul 1, 2024

Sounds good! Let's see how it runs on the other one

@MOchiara
Copy link
Member Author

MOchiara commented Jul 1, 2024

Why is mine so slow?

@MOchiara
Copy link
Member Author

MOchiara commented Jul 1, 2024

Wohooooo!

@callumrollo callumrollo merged commit 55bb788 into OceanGlidersCommunity:main Jul 1, 2024
9 checks passed
@callumrollo callumrollo mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants