[FEAT] Added function to create nice labels and units #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tried the possible new doc string format with We can see if we like it and if so I will change all the other functions |
callumrollo
reviewed
Dec 5, 2024
glidertest/utilities.py
Outdated
| if var in label_dict: | ||
| units = f'{label_dict[var]["units"]}' | ||
| else: | ||
| units= f'{ds[var].units}' |
There was a problem hiding this comment.
recommend a further catch for variables without units
if var in label_dict:
return f'{label_dict[var]["units"]}'
elif 'units' in ds[var].attrs:
return f'{ds[var].attrs['units']}'
else:
return ""| var : The name of the variable to plot. Default is 'DOXY'. | ||
|
|
There was a problem hiding this comment.
As a general guidance, try not to add these stylistic fixes to unrelated code in a PR, it makes the review process more confusing! You can do a seperate PR that just fixes typos and style etc. Or, if you're feeling extra cool, you can check out python linters like astral
We can leave them in for this PR though :)
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
sorry I broke ur tests 😢 |
callumrollo
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not added all possible variables to the dictionary (and I am not sure I am doing this the right way either).
I have not modified the labels for eleanors functions either