[FEAT] Add plot that shows the max depth of each profile #159
Conversation
tillmrtz
commented
Dec 3, 2024
•
tillmrtz
commented
|
To do:
|
| @@ -1305,3 +1305,38 @@ def plot_ioosqc(data, suspect_threshold=[25], fail_threshold=[50], title='', ax= | |||
| if force_plot: | |||
| plt.show() | |||
| return fig, ax | |||
|
|
|||
| def plot_max_depth_per_profile(ds: xr.Dataset, bins= 20, **kw: dict) -> tuple({plt.Figure, plt.Axes}): | |||
| """ | |||
There was a problem hiding this comment.
add ax as a parameter
ax=None
And add below the
if ax is None:
fig, ax = plt.subplots()
force_plot = True
else:
fig = plt.gcf()
force_plot = False
There was a problem hiding this comment.
You can check the other examples and the end you would put also
if force_plot:
plt.show()
There was a problem hiding this comment.
Changed to:
if ax is None:
fig, ax = plt.subplots(1,2)
force_plot = True
I hope this is correct, since I want to plots, like in plot_outlier_duration()
glidertest/plots.py
Outdated
| ax[0].set_xlabel('Profile Number') | ||
| ax[0].set_ylabel('Max Depth') | ||
| ax[0].set_title('Max Depth per Profile') | ||
| ax[0].grid() |
There was a problem hiding this comment.
Maybe to avoid repetition you can do a
[a.grid() for a in ax]
glidertest/plots.py
Outdated
| max_depths = group_profiles.values | ||
| profile_nums = group_profiles.profile_num.values | ||
| with plt.style.context(glidertest_style_file): | ||
| fig, ax = plt.subplots(1, 2, figsize=(18, 6)) |
There was a problem hiding this comment.
The figure size is already specified in the glidertest_style_file and is 14,10
We do change it in the function when we make them smaller (ex. plot_basic_vars)
I suggest we keep the standard size and resize later if desired by specifying the figure size
There was a problem hiding this comment.
Deleted the figsize adjustment
glidertest/plots.py
Outdated
| with plt.style.context(glidertest_style_file): | ||
| fig, ax = plt.subplots(1, 2, figsize=(18, 6)) | ||
| ax[0].plot(profile_nums, max_depths,**kw) | ||
| ax[0].set_xlabel('Profile Number') |
There was a problem hiding this comment.
We are generally using capital letter only for the first 'word' so maybe change to 'Profile number'
glidertest/plots.py
Outdated
| fig, ax = plt.subplots(1, 2, figsize=(18, 6)) | ||
| ax[0].plot(profile_nums, max_depths,**kw) | ||
| ax[0].set_xlabel('Profile Number') | ||
| ax[0].set_ylabel('Max Depth') |
There was a problem hiding this comment.
Same as before maybe use 'Max depth' and add units in round paranthesis
glidertest/plots.py
Outdated
| ax[0].plot(profile_nums, max_depths,**kw) | ||
| ax[0].set_xlabel('Profile Number') | ||
| ax[0].set_ylabel('Max Depth') | ||
| ax[0].set_title('Max Depth per Profile') |
There was a problem hiding this comment.
Same here with the capitall letters
glidertest/plots.py
Outdated
| ax[1].hist(max_depths, bins=bins) | ||
| ax[1].set_xlabel('Max Depth') | ||
| ax[1].set_ylabel('Number of Profiles') | ||
| ax[1].set_title('Histogram of Max Depth per Profile') |
There was a problem hiding this comment.
ax[1] labels and title without the extra capital letters
glidertest/plots.py
Outdated
| fig = plt.gcf() | ||
| force_plot = False | ||
|
|
||
| ax[0].plot(profile_nums, max_depths,**kw) |
There was a problem hiding this comment.
You can avoid creating a new variable and just say:
ax[0].plot(max_depths.profile_num, max_depths,**kw)
|
Looks good! You now want to make the tests and add this function to the demo |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
All changes approved |
