add sampling periods

[LouClement]

No description provided.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[callumrollo]

Hi Louis, thanks for the PR! Just a couple of changes I'd recommend:

• vars is a built in python function, so should not be used as a variable name. Consider variable or variables instead (see a full list of built ins here https://docs.python.org/3/library/functions.html).
• Following the conventions of other functions, plot_sampling_period_all should return fig, ax so that the user can make additional changes to the plots/easily save them.

Thank you for including example usage and tests.

Also try to avoid making a PR from your main branch! It's good practice to develop on a dedicated branch, so that if other PRs are merged while we work on this one you can pull those changes in. Should be fine this time though as this is the only open PR

[callumrollo]

merged in #145