Fix card dnd issue with visibility

ObeoNetwork · Feb 13, 2024 · 5797103 · 5797103
1 parent 1eac2f9
commit 5797103
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ObeoNetwork/react-trello",
-  "version": "2.4.8",
+  "version": "2.4.9",
   "description": "Pluggable components to add a trello like kanban board to your application",
   "main": "dist/index.js",
   "files": [

diff --git a/src/controllers/Lane.js b/src/controllers/Lane.js
@@ -163,9 +163,9 @@ class Lane extends Component {
     const showableCards = collapsed ? [] : cards
 
     const cardList = this.sortCards(showableCards, laneSortFunction).map((card, idx) => {
-      if (card.visible || card.visible === undefined) {
-        const onDeleteCard = () => this.removeCard(card.id)
-        const cardToRender = (
+      const onDeleteCard = () => this.removeCard(card.id)
+      const cardToRender =
+        card.visible || card.visible === undefined ? (
           <components.Card
             key={card.id}
             index={idx}
@@ -181,13 +181,12 @@ class Lane extends Component {
             t={t}
             {...card}
           />
-        )
-        return cardDraggable && (!card.hasOwnProperty('draggable') || card.draggable) ? (
-          <Draggable key={card.id}>{cardToRender}</Draggable>
-        ) : (
-          <span key={card.id}>{cardToRender}</span>
-        )
-      }
+        ) : null
+      return cardDraggable && (!card.hasOwnProperty('draggable') || card.draggable) ? (
+        <Draggable key={card.id}>{cardToRender}</Draggable>
+      ) : (
+        <span key={card.id}>{cardToRender}</span>
+      )
     })
 
     return (
@@ -278,6 +277,7 @@ class Lane extends Component {
       editable,
       editLaneTitle,
       collapsed: collapsedProps,
+      onLaneCollapseUpdate,
       ...otherProps
     } = this.props
     const allClassNames = classNames('react-trello-lane', this.props.className || '')