CMSIS RTOS Feature #253
Merged
CMSIS RTOS Feature #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
atsju
reviewed
Aug 1, 2021
There was a problem hiding this comment.
than you for the changes. We are almost done. I made some small remarks but I have one main issue in that the example is not working 100% on my side:
Please note the F4 build fails with following options on my computer. Please confirm issue and we can investigate further if you can not reproduce.
option(USE_CMSIS_RTOS "Use CMSIS RTOS provided by Cube repository" OFF)
option(USE_CMSIS_RTOS_V2 "Use CMSIS RTOS_V2 provided by Cube repository" OFF)
option(USE_CUBE_FREERTOS "Use the FreeRTOS kernel provided by the Cube repository" ON)
| endif() | ||
|
|
||
| # Component is not RTOS component, so check whether it is a family component | ||
| string(REGEX MATCH "^STM32([A-Z][0-9])([0-9A-Z][0-9][A-Z][0-9A-Z])?_?(M[47])?.*$" COMP ${COMP}) |
| @@ -1,122 +1,216 @@ | |||
| set(FreeRTOS_PORTS ARM_CM0 ARM_CM3 ARM_CM4F ARM_CM7 ARM_CM4_MPU ARM_CM3_MPU ARM_CM7_MPU) | |||
There was a problem hiding this comment.
just reminder of #231 (do not fix here)
| target_link_libraries(FreeRTOS::Coroutine INTERFACE FreeRTOS) | ||
| if(STM32H7 IN_LIST FreeRTOS_FIND_COMPONENTS) | ||
| list(REMOVE_ITEM FreeRTOS_FIND_COMPONENTS STM32H7) | ||
| list(APPEND FreeRTOS_FIND_COMPONENTS STM32H7_M7 STM32H7_M4) |
1. include for device print function not necessary anymore 2. Improved component convention for H7 example 3. Fixed possible bug in F4 example component logic, is also consistent now 4. Some clarifications and form improvements for FreeRTOS section in README
|
Changes from code review:
Can you check the |
atsju
approved these changes
Aug 2, 2021
Hish15
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full discussion and review can be found here: #227 . This is the squashed version of the feature for a cleaner history and with a proper git commit for the PR.
This branch has the complete feature set for CMSIS RTOS support.
Builds on #190 and #189 , a lot of work provided by @g-arjones , extended with documentation and an updated
freertosexample with the same architetecture as #225Closes #227
Closes #188 . Closes #160 issues
Closes #190 Closes #189 PR
The updated
freertosexample can now be compiled with CMSIS RTOS by passing-DUSE_CMSIS_RTOS=ONand CMSIS RTOSV2 by passing-DUSE_CMSIS_RTOS_V2=ON. When doing this, it is not necessary to setFREERTOS_PATHanymore, because the build system can use the FreeRTOS and CMSIS RTOS sources inside the Cube repository. See updated README for more details