feat: Challenge 41 based on Password shucking #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adarsh A <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…n adoc Signed-off-by: Adarsh A <[email protected]>
commjoen
requested changes
Oct 16, 2023
There was a problem hiding this comment.
Your third challenge already within a month! @adarsh-a-tw : you rock sir!
Here are some minor changes . @bendehaan do you have time for a textual review please?
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge41.java
Outdated
Show resolved
Hide resolved
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge41.java
Outdated
Show resolved
Hide resolved
| value = "WEAK_MESSAGE_DIGEST_MD5", | ||
| justification = "This is to allow md5 hashing") | ||
| private String hashWithMd5(String plainText) throws NoSuchAlgorithmException { | ||
| MessageDigest md = MessageDigest.getInstance("MD5"); |
Check failure
Code scanning / CodeQL
Use of a broken or risky cryptographic algorithm
Signed-off-by: Adarsh A <[email protected]>
commjoen
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
That's number 3 already! Wow! that's amazing @adarsh-a-tw !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
Adds challenge 41 which leaks passwords based on password shucking.
Relations
Closes #859
Checklist: