Sensitive Data Leaked via Screenshots (by @guardsquare) #3112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serek8
changed the title
cpholguera
reviewed
Jan 17, 2025
| - Screenshots not deleted when backgrounding | ||
| - Auto-Generated Screenshots | ||
| - https://developer.apple.com/documentation/uikit/uiscreen/2921651-iscaptured | ||
| - https://developer.apple.com/documentation/uikit/uitraitcollection/scenecapturestate | ||
| status: draft |
There was a problem hiding this comment.
Suggested change
| status: draft | |
| status: new |
| - Screenshots not deleted when backgrounding | ||
| - Auto-Generated Screenshots | ||
| - https://developer.apple.com/documentation/uikit/uiscreen/2921651-iscaptured | ||
| - https://developer.apple.com/documentation/uikit/uitraitcollection/scenecapturestate | ||
| status: draft | ||
|
|
||
| --- | ||
|
|
There was a problem hiding this comment.
Mitigations section missing
Comment on lines
-18
to
-19
| - Screenshots not deleted when backgrounding | ||
| - Auto-Generated Screenshots |
There was a problem hiding this comment.
what about these 2 topics? Shouldn't we add them as Modes of Introduction & tests?
cpholguera
requested changes
Jan 30, 2025
| @@ -0,0 +1,30 @@ | |||
| --- | |||
| platform: ios | |||
| title: References to Screen Capturing API | |||
There was a problem hiding this comment.
How about?
Suggested change
| title: References to Screen Capturing API | |
| title: Uses of Screen Capturing APIs with r2 |
| @@ -0,0 +1,28 @@ | |||
| --- | |||
| title: References to Screen Capturing API | |||
There was a problem hiding this comment.
Suggested change
| title: References to Screen Capturing API | |
| title: References to Screen Capturing APIs |
| --- | ||
| title: References to Screen Capturing API | ||
| platform: ios | ||
| id: MASTG-TEST-0240 |
| @@ -0,0 +1,26 @@ | |||
| --- | |||
| title: Sensitive Data Leaked via Screenshots | |||
There was a problem hiding this comment.
what about?
Suggested change
| title: Sensitive Data Leaked via Screenshots | |
| title: References to Screen Capturing Prevention APIs |
| platform: android | ||
| id: MASTG-TEST-0216 | ||
| type: [static] | ||
| weakness: MASWE-0055 |
There was a problem hiding this comment.
Please add best-practices:
| platform: ios | ||
| id: MASTG-TEST-0240 | ||
| type: [static] | ||
| weakness: MASWE-0055 |
There was a problem hiding this comment.
Please add best-practices:
| @@ -0,0 +1,29 @@ | |||
| --- | |||
| platform: android | |||
| title: Sensitive Data Leaked via Screenshots | |||
There was a problem hiding this comment.
Suggested change
| title: Sensitive Data Leaked via Screenshots | |
| title: Uses of FLAG_SECURE with semgrep |
|
|
||
| ### Evaluation | ||
|
|
||
| The test succeeds because the app contains API that detects screen capturing. It's difficult to say whether the app actually uses this API but its presence indicates that the developer is aware of this API. |
There was a problem hiding this comment.
...or if it applies to the relevant screens (?)
Comment on lines
+13
to
+14
| - [FLAG_SECURE](https://developer.android.com/security/fraud-prevention/activities#flag_secure) - prevents screen recording | ||
| - [DETECT_SCREEN_CAPTURE](https://developer.android.com/about/versions/14/features/screenshot-detection#implementation) - detects when a screenshot is taken |
There was a problem hiding this comment.
Suggested change
| - [FLAG_SECURE](https://developer.android.com/security/fraud-prevention/activities#flag_secure) - prevents screen recording | |
| - [DETECT_SCREEN_CAPTURE](https://developer.android.com/about/versions/14/features/screenshot-detection#implementation) - detects when a screenshot is taken | |
| - [`FLAG_SECURE`](https://developer.android.com/security/fraud-prevention/activities#flag_secure): prevents screen recording. | |
| - [`DETECT_SCREEN_CAPTURE`](https://developer.android.com/about/versions/14/features/screenshot-detection#implementation): detects when a screenshot is taken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2695